Having some trouble with a part of a script. I'm trying to add an ability to the player when you use a specific shout.

Here's what I've got:

stuff...Spell Property YourAbilityTwo AutoSpell Property YourShoutOne AutoSpell Property YourShoutTwo AutoSpell Property YourShoutThree Auto...stuff...Event OnSpellCast(Form akSpell)	If(akSpell == YourShoutOne || akSpell == YourShoutTwo || akSpell == YourShoutThree)		Game.GetPlayer().AddSpell(YourAbilityTwo)		Utility.Wait(10)		Game.GetPlayer().RemoveSpell(YourAbilityTwo)		debug.notification("Removed")	EndIfEndEvent

The shout is not adding the ability to the player or displaying the "Removed" text.

http://www.creationkit.com/OnSpellCast_-_ObjectReference is the creation kit wiki page on the event. I'm not sure I understand exactly how to use this event. What I find confusing in the example is the line:

Spell spellCast = akSpell as Spell 

Can anyone help me out here?

Try:

stuff...Spell Property YourAbilityTwo AutoSpell Property YourShoutOne AutoSpell Property YourShoutTwo AutoSpell Property YourShoutThree Auto...stuff...Event OnSpellCast(Form akSpell)        Spell spellCast = akSpell	If(spellCast == YourShoutOne || spellCast == YourShoutTwo || spellCast == YourShoutThree)		Game.GetPlayer().AddSpell(YourAbilityTwo)		Utility.Wait(10)		Game.GetPlayer().RemoveSpell(YourAbilityTwo)		debug.notification("Removed")	EndIfEndEvent

Might make a difference.

Are all your properties filled?

Nope, It actually didn't compile, but I added this:

Spell spellCast = akSpell as Spell

It compiles but still doesn't work. I checked all the properties again and they're all right.

Correct me if I'm wrong: but http://www.creationkit.com/Spell_Script is not the same as http://www.creationkit.com/Shout_Script. OnSpellCast() is only fired on Spell, Enchantment, Potion, or Ingredient.

Did your OnSpellCast() gets fired at all?

I'd rather not use an SKSE event. My mod doesn't require it yet and I want to keep it that way.

Yeah it doesn't fire at all. Which is strange because Shouts are classified as spells in the CK. I guess it isn't possible without SKSE.

Shouts are a bit strange. They use spells to do their damage and cause their effects, but they aren't technically spells when they're cast I guess.

It's still possible to do what you want without using SKSE though. Here's one possibility (there may be others) -

Use kuertee's method of http://www.creationkit.com/Passing_Conditions_to_Papyrus, combined with http://www.creationkit.com/IsPlayerActionActive to generate an event every time the player shouts.

How about OnMagicEffectApply()? You could catch the 'underlying' Spell's MagicEffect?

That would work too, especially if you're trying to detect shouts that affect the player.

Though if you want to detect when the player is using shouts with a magic effect that is supposed to hit other things (like Unrelenting Force), it would be a bit trickier, since OnMagicEffectApply would need to be in a script attached to whatever is hit by the shout's magic effect.

Yeah I've made an OnEffectStart() version that works. It adds the ability but only when you hit something. I want it to add regardless of hitting anything.

Thanks, I'll give this a try and report back with the results.

Ah ok, then egocarib's suggestion should be the best solution.

Small note: I just edited the Passing Conditions To Papyrus page to clarify a detail in step 4 of kuertee's instructions - you need to make sure you add the condition to the Effect Item in your ability (not to the Magic Effect itself, as the original instructions could have been interpreted to mean).

This is because conditions on the Effect Item in the ability will update every second, but conditions on the Magic Effect will only be checked when the ability first is added to the player.

I made the ability with a magic effect that runs a script, just like in the tutorial. I added it to the player using a quest, and it was invisible in the UI even though I have "Hide in UI" unchecked. The script on the magic effect NEVER ran, even with no conditions on the magic effect. I'm wasn't sure that you can add an ability with a magic effect archetype "script". So I changed the effect architype to cloak and the ability still didn't show up in the UI.

I'm really confused now because I'm adding another ability with the same quest in exactly the same way and it works fine, but this new ability never shows up at all in the active effects menu.

Not really sure what I did but it's adding now.

So everything is working now except the condition function GetSpellHasKeyword (ShoutFireBreath) == 1. If I remove that, the shout adds the ability to the player fine.

How else could I check to make sure the player is only using the flame breath shout?

Got it! It's GetEquippedShout (FireBreathShout) == 1

For some reason the shout doesn't trigger the script when I'm in combat. Anyone know whats going on with that?

After some testing, i found that the ability will trigger with wolves nearby, as long as they aren't in combat with you. As soon as they enter combat with you, you cant trigger the ability. I still have no idea why this is happening though.