The mod I am working on currently has an issue of slow downs once in a while (the game freezes for a split second) that are caused I think by the redundant projectile reference list each actor uses.

When ever any projectile is shot (spell or arrow) all npc and the player all run a "walk the cell" script to see if the projectile is a candidate for tracking.

If the projectile is a tracking candidate another script checks the ref to see if and when it is about to hit the tracking actor/player. I do this by doing many checks such as comparing the direction of the projectile to the position of the npc or player and how much closer it is to the actor / player then other projectiles.

The slow down does not seem to happen because of the second script only when the first walk the cell script runs becasue (I think) all the npc and player walk the cell for projectiles at the same time. So I want to instead make a master array list that all the actors and the player will use instead, however I don't know how to completely do this yet. I will need to ask the OBSE guys about this, but first I want to TRY to cobble a script together first the best I can.

My problem is I only understand about half of what I need to understand concerning arrays and how to build them and then access the ref in them, and finally remove refs from them that are not valid anymore.

Here is my firs attempt to gather projectiles refs into an master array. please make corrections (if you understand arrays) to this script so that it will actually WORK:

scn aadpTestRef NextItemRef mearray_var ListOfProjectilesbegin gamemodeif eval (ar_Size ListOfProjectiles) == 0let ListOfProjectiles := ar_Construct Array; Create the listsendifif  Radar > 0;--- see Note 2set nextItem to GetFirstRef 34 1;--- most likely the last projectile put into the cell      if eval (ar_Size ListOfProjectiles) > 0 && ( NOTE 1)      let index := 0      While index < ar_Size ListOfProjectiles      let Nextitem := ListOfProjectiles[index];--- add to the array list of arrows      	      if (Nextitem != 0 && IsFormValid Nextitem);--- Check to see if the ref is still valid      	          Set index to index + 1       	          else      	          ar_Erase ListOfProjectiles index;--- Not legal formId, so just remove it from the list       	      endif      set nextItem to getNextRef      loop      endifendifend

Note 1: some obse array command to check that nextItem is not already in the array list.
Note 2: radar is a count of frames that is set to greater than 0 when ever any actor or the player fires a spell or arrow. This I have working already so I am not worried about this part.

I would like to help, but doesn't understand well enough exactly what you are trying to do. Can you try to explain it in more detail?

Thank you so very much TheNiceOne, I was getting worried no one with array understanding was perusing the CS topics.
I want to add projectile references to a master array each time a projectile is fired by the player or by an NPC.

I already have a trigger (called RADAR) for when the NPC or player fires a projectile. But I do not have a working script to add the projectiles to the master array.
After I have a working master array for projectiles (spells or arrows) flying thru the air in the players cell I will have each NPC and the player walk this array once in a while when they need a new projectile reference to track.

But that part is not what I am worried about at this time. Right now I just need a working script to add projectiles to an array when my RADAR short is greater than 0.
I need to be sure all the projectile ref in the master array are valid and remove invalid refs as well each time a new ref is added to the master array.

This is for my Combat Magic mod.

see here:

http://www.youtube.com/watch?v=ZTOynB6Z-Rw

I need the player and NPC to track projectiles so that their magic Shields will act on the projectiles when the projectiles are close enough to them. Again I already have that part working, but I am doing it by having each NPC and the player walk the cell each time a projectile is fired. Thus each NPC and the player run cell walking scripts all at the same time when a projectile is fired.

I want to make my mod more efficient by using a master array of the projectiles flying in the air instead.

My RADAR is set to 3 by any NPC or the player when they fire a spell or arrow. RADAR is then reduced to 0 by subtracting 1 each FRAME of game time. So this master array needs to be updated when RADAR is greater than 0. RADAR is working great so do not worry about that part of the script.

Since TNO does not seem to be around, I will give it a shot:

First, to be used by many scripts, the array should be in a quest. So I am assuming a quest named MyQuest, but it could be any of your existing quests.

Second, I don't see the need of all the troubles of adding and removing items. It seems more efficient just rebuilding the array from scratch, when needed.

Third, I would create a function to do that, so it may be called from whichever script may need it:

scn aadpRebuildListOfProjectilesRef NextItemarray_var ListOfProjectilesbegin Function {}let MyQuest.ListOfProjectiles := ar_Construct Array; Create the listsset nextItem to GetFirstRef 34 1while nextItem	ar_append MyQuest.ListOfProjectiles nextItem	set nextItem to getNextRefloopend

Fourth, call the function when you need the array to be updated. From your description, I would say you called it every time you set RADAR to something not-zero

call aadpRebuildListOfProjectiles

Disclaimer: I am not familiar with handling projects, so I may be missing something here.

I would concur with QQuix. Usually you don't worry about trying to track things down in an array - you just rebuild it every few frames.

Here's a snippet from the Oblivion XP killing script:

	let cellScanTimer := cellScanTimer + getSecondsPassed	if ( arrayNPC ) && ( cellScanTimer >= ObXPSettings.cellScanDelay )		if eval ( ar_Size arrayNPC )			;clean up NPC array to prevent having NULL references at the end of the array			ar_Erase arrayNPC 0:ar_Size arrayNPC		endif

The cellScanDelay is set to 5 seconds. Since this is in the killing script, an actor is removed from the arrayNPC when he or it is killed (using ar_erase with the specific index of the element).

Oblivion XP uses a lot of arrays, so if you want some examples, you could have a look at it. The killing script is similar to what you're trying to do, except it's an array of NPC's and creatures (i.e. targets!). I could also post the contents of one or two of the scripts here if you want.

QQuix, Andalaybay and TheNiceOne, THANK YOU VERY VERY MUCH!

Normally I have a rule that I do not use scripts (in my mods) written by others that I do not fully understand. But I am so lost on the specific array commands (what they do and how to use them) that I need to break that rule. I find myself in a position to beg you guys to write this for me "more than less". And then hope that while I plug in your work into my mod I will eventually absorb the concepts and the exact meaning of the commands used.

I like the idea of re-creating the array EACH cycle to keep it clean, that really makes a lot of sense to me.

so.... lets see now...I really do not need the master array script to be a function because this will only be done in my main quest script each time the RADAR is set to 3. I have no reason for it to be called from any other scripts.

if ProjRadar == 3set ProjRadar to 2let ListOfProjectiles := ar_Construct Array; Create the listsset TempProjectile to GetFirstRef 34 1while TempProjectile	ar_append ListOfProjectiles TempProjectile	set TempProjectile to getNextRefloopendif 

This is very good as it is small and I feel I can use this "comfortably" in my mod.


So now comes the more complicated part, accessing the array when each NPC or the player needs to assign a projectile reference to their tracking.

Here is what I have working right now, please excuse the "no indents", but I do not need any help on the following script I just wanted to show you what I am doing to give an idea of what I am up to :

;;;;;;;;Grab and track spell or Projectile ref for this NPCif FlyingProjectile == 0 && aaDPCMMainQUEST.ProjRadar > 0set FlyingProjectileOld to GetFirstRef 34 1set TempProjectile to FlyingProjectileoldWhile (FlyingProjectileOld)if IsFormValid FlyingProjectileOld == 1if FlyingProjectileold.getdisabled == 0if FlyingProjectileold.GetMagicProjectileSpell != aadpPlasmaBoltfakeif FlyingProjectileOld.getprojectiletype == 2 || FlyingProjectileOld.getprojectiletype == 1set NewSpell to FlyingProjectileOld.GetMagicProjectileSpellif IsSpellHostile NewSpell == 0breakendifendifif FlyingProjectileold.getprojectilesource != OSNPCUser && FlyingProjectileold.getprojectilesource != OSTZEffect && FlyingProjectileold.getprojectilespeed != 0 && FlyingProjectileold.getprojectilelifetime < 12if ( FlyingProjectileold.GetHeadingAngle OSNPCUser > -10 ) && ( FlyingProjectileold.GetHeadingAngle OSNPCUser < 10 )if FlyingProjectileold.getdistance OSNPCUser <= TempProjectile.getdistance OSNPCUser if ( ( OSNPCUser.GetHeadingAngle FlyingProjectileold ) + offset >= -45 ) && ( ( OSNPCUser.GetHeadingAngle FlyingProjectileold ) + offset <= 45 )set FlyingProjectile to FlyingProjectileoldset TempProjectile to FlyingProjectileoldendifendifendifendifendifendifendifset FlyingProjectileOld to getnextrefloopendif;Check for things that could change after the projectile ref is grabed from the air.if FlyingProjectile != 0if IsFormValid FlyingProjectile != 1set FlyingProjectile to 0elseif FlyingProjectile.getdisabled == 1 || FlyingProjectile.getprojectilelifetime >= 12set FlyingProjectile to 0elseif FlyingProjectile.getprojectilespeed == 0set FlyingProjectile to 0elseif ( FlyingProjectile.GetHeadingAngle OSNPCUser >= 20 ) || ( FlyingProjectile.GetHeadingAngle OSNPCUser <= -20 ) || ( OSNPCUser.GetHeadingAngle FlyingProjectile + offset < -45 ) || ( OSNPCUser.GetHeadingAngle FlyingProjectile + offset > 45 )set FlyingProjectile to 0endifendifif FlyingProjectile != 0  Set Curypos to ( FlyingProjectile.Getpos y )  Set Curxpos to ( FlyingProjectile.Getpos x )  Set Curzpos to ( FlyingProjectile.Getpos z )If ( Curxpos == oldxpos && Curypos == oldypos && Curzpos == oldzpos ) || FlyingProjectile.getangle y != 0FlyingProjectile.setprojectilespeed 0 set FlyingProjectile to 0endif;;;;;Projectile has not stopped if none of aboveSet oldypos to CuryposSet Oldxpos to CurxposSet Oldzpos to Curzpos - ( FlyingProjectile.getprojectilelifetime )FlyingProjectile.setpos z oldzposendif

BUT now I need to change it just a little to use the master array list instead of the cell walking, I will indent now as I do need help on the script:

;;;;;;;;Grab and track spell or Projectile ref for this NPCif FlyingProjectile == 0 && aaDPCMMainQUEST.ProjRadar == 2   set FlyingProjectileOld to THE NEXT REF IN THE MASTER ARRAY <---------------------------------  what do I do here?  set TempProjectile to FlyingProjectileold     While (FlyingProjectileOld)        if IsFormValid FlyingProjectileOld == 1           if FlyingProjectileold.getdisabled == 0              if FlyingProjectileold.GetMagicProjectileSpell != aadpPlasmaBoltfake                          if FlyingProjectileOld.getprojectiletype == 2 || FlyingProjectileOld.getprojectiletype == 1                          set NewSpell to FlyingProjectileOld.GetMagicProjectileSpell                              if IsSpellHostile NewSpell == 0                                 break                              endif                          endif                                     if FlyingProjectileold.getprojectilesource != OSNPCUser && FlyingProjectileold.getprojectilesource != OSTZEffect && FlyingProjectileold.getprojectilespeed != 0 && FlyingProjectileold.getprojectilelifetime < 12                                        if ( FlyingProjectileold.GetHeadingAngle OSNPCUser > -10 ) && ( FlyingProjectileold.GetHeadingAngle OSNPCUser < 10 )                                            if FlyingProjectileold.getdistance OSNPCUser <= TempProjectile.getdistance OSNPCUser                                                 if ( ( OSNPCUser.GetHeadingAngle FlyingProjectileold ) + offset >= -45 ) && ( ( OSNPCUser.GetHeadingAngle FlyingProjectileold ) + offset <= 45 )                                                  set FlyingProjectile to FlyingProjectileold                                                  set TempProjectile to FlyingProjectileold                                                endif                                            endif                                        endif                                     endif              endif        endif    endif    set FlyingProjectileOld to getnextref <-----------------------  and this needs to change obviously  loopendif

Radar will then be set to 0 on the 3rd frame after it was set to 3.

if RadarFrame == 2
set ProjRadar to 0
set RadarFrame to 0
elseif ProjRadar > 0
set RadarFrame to RadarFrame + 1
endif

I'd need more time to go through your scripts, but I just wanted to mention that arrays are not limited to one dimension. In other words, you can have arrays of arrays.

Not sure if this applies to your situation, but you could have:
[actor1][projectile1]
[actor1][projectile2]
... and so on.

In Oblivion XP I have:
arrayNPC[i][0] = actor reference
arrayNPC[i][1] = combat status of companion
arrayNPC[i][2] = number of party member in combat with actor
arrayNPC[i][3] = player level

where actor is the combat target. Not much of this is going to make sense out of context, but the point is that you can have the first dimension be the array of actors and the second dimension be various attributes of the actor. So from a quick look at your scripts, I wonder if you can optimize things a bit by considering multi-dimensional arrays.

Sometimes it may make sense to have such things as functions anyway, to make the main script easier to read, but that depends on how complicated the main script is.





There are two main ways to iterate through an array. The one that probably looks most natural, is to use an index variable that is increased by one for each iteration, and then you stop when the index variable has reached the end:

short index...if FlyingProjectile == 0 && aaDPCMMainQUEST.ProjRadar == 2 	set TempProjectile to FlyingProjectileOld 						set index to 0	While (index < ar_Size ListOfProjectiles)		set FlyingProjectileOld to ListOfProjectiles[index]			; I think you may need to use "let FlyingProjectileOld := ListOfProjectiles[index]" when accessing arrays		...		; everything between this is the same as before		...		set index to index + 1 ; let index += 1 does the same, but slightly faster	loopendif

The second, and probably slightly faster is to use the built-in array iterator function, ForEach:

array_var projectile...if FlyingProjectile == 0 && aaDPCMMainQUEST.ProjRadar == 2 	set TempProjectile to FlyingProjectileold	ForEach projectile <- ListOfProjectiles				; Iterates through the entire ListOfProjectiles array, and assigns the content to projectile		set FlyingProjectileOld to *projectile			; I think you may need to use "let FlyingProjectileOld := *projectile"  when accessing arrays		; everything below, inside the loop this is the same as before, but without any line to get next item, since that is handled automatically by ForEach/Loop	loopendif

As said, those two effectively does the same, but I would guess the latter is slightly faster. For the latter, the difficult to understand part is probably the projectile array, but here is a short-hand of what the projectile array gets assigned to:

projectile["Value"] = content of one ListOfProjectiles itemprojectile["Key"] = the index in ListOfProjectiles for that item*projectile == projectile["Value"]

So the first time in your loop, projectile["Value"] gets assigned the first arrow (or whatever are in the array), while projectile["key"] is 0. The second time in the loop, projectile["Value"] gets assigned the second arrowand while projectile["key"] 1, etc. "*projectile" is just a short-hand (that's natural for C/C++ programmers) for "projectile["Value"]".

I want to thank you guys very much for you time and patients with me .
I did get your scripts working and I may have learned a little as well.

I have more questions but for now I am just too hampered by my Internet connection to participated/mod without it being infuriating process.
I am severely handicapped by my ridiculously slow Internet connection. This issue started a month or so ago and has gotten worse each week.

I may not be able to post often for the foreseeable future. I cannot watch any steam videos and my browser times out often when I try to download files. It takes 15 minutes just to log into this site so I can post, and my posts often get dumped as I write them. I have no options at this time for a better connection.

If this continues I may need to just take a break from the Internet and just play fallout Vegas for a while ...IF I CAN EVEN LOAD THE GAME DVD's WITHOUT A DECENT INTERNET CONNECTION!

I hate cloud computing...