Nice. Can't wait :thumbsup:

@WalkerInShadows

Next version fixes the issue... check out this preview picture: http://www.tesnexus.com/downloads/images/26196-1-1249270124.JPG

Very nice. I can definitively say that something in your mod was indeed causing my hotkey issue with Septim Mansion - after I uninstalled it, the SM teleport spell remained bound after being cast, like it should. No other spell or item had that problem, so it might be something with the fact that it gets replaced with the other spell. I don't know if that other spell takes up the same hotkey slot (I'll have to check), but it could be causing problems with assigned icons.

Oh! Now I'm drooling...

Just place my comment here and it'll be fine. Who knows? Maybe I came from the future thinking said feature was already added.

Ah, I'm just joking. I'm loving the addition immensely. Thanks again! :tops:

Version 2 Released!
- Bugs fixed, annoying issues resolved
- See custom icons in your spellbook
- Set icons without leaving your inventory/spellbook
- Copy icons from one spell to another
- Tools for modders to add custom icons to their own mods

I have a bug report
With the new version, whenever I set an icon using the lesser power, it shows up fine in the inventory, but is the script effect icon in the HUD. This is sad

Misc Bug Report:
The first time I start a SaveGame with your mod active (i.e. the SaveGame was created without your mod Active) my currently equipped Spell changes to "010030FD": CSIDummySpell). It doesn't get added to the Spellbook, though.

Nothing serious, but still annoying.

I can't reproduce this one, can you give me more details?



When you load a game, CSI needs to refresh your spell icon by selecting the dummy spell then putting back your previous spell (since UI stuff doesn't get saved). If you happened to remove a mod that contained the spell you had selected when you saved the game, I could see this happening. CSI can't restore the previous spell when it doesn't exist.

It's a Vanilla-Spell (00000000 (Console Output of GetPlayerSpell): the Healing-Spell from the beginning, should be DefaultPlayerSpell), so I didn't remove the mod.
Maybe the FormID is the cause of the Problem, but from my experience checking against the EditorID works without problems (Although GetPlayerSpell seems to have problems when called several times in one frame --> Variable).

Any spell I give a custom icon to shows up fine in the spellbook, but the icon in gamemode is my script effect icon - regardless of which school it's in. I cleansaved when I installed, and v1 still works fine, so perhaps it's just me? :S

:huh: Never heard of this problem, though that might explain it... except GetPlayerSpell is only used in assignment once per frame (and only potentially called twice), and if this was the problem you wouldn't just see it on loading.

I found this in the wiki documentation:



Maybe on game load you have a mod that removes the active spell for a couple frames, which would result in the problem you have described.



Does the icon show when you set it from your inventory using the 'I' key?

Same behaviour, alas. Could UI mods have any bearing on this?

Maybe. Do you have a UI mod that does something unusual to the HUD?

Nothing weird, just good ol' DarkUI'd DarN.

Found it because a code like this didn't work:

scn LPCSBActiCheckCurrentSpellScriptref rSpellarray_var aIteratorBegin OnActivate	let rSpell := GetPlayerSpell	if ( Player.HasSpell rSpell == 0 ) && ( GetObjectType rSpell == 16 )		DebugPrint "%aLPCSB:%a Player has equipped a hidden Spell -> Search other Spell", 2, 3		ForEach aIterator <- ( Player.GetSpells )			let rSpell := aIterator["Value"]			if ( GetSpellType rSpell == 1 ) || ( GetSpellType rSpell == 4 )		;Disease || Ability				Continue			else				SelectPlayerSpell rSpell				Break			endif					Loop		if ( Player.HasSpell rSpell == 0 )			DebugPrint "%aLPCSB:%a No Spell found -> Search for Scrolls", 2, 3			ForEach aIterator <- ( Player.GetItems 21 )				let rSpell := aIterator["Value"]				if ( GetBookIsScroll rSpell )					SelectPlayerSpell rSpell					Break				endif			Loop		endif		let aIterator := ar_Null	endifEnd

I think sth. like this is better then just leaving a (hostile) dummy spell selected.
Or you just switch back to DefaultPlayerSpell, at least this wouldn't hurt anyone. ^^



Btw: The change to the DummySpell occurred only with DefaultPlayerSpell.



OK, question was not for me, but I have a similar behavior:
Changing the Icon of a SpellEffect using I works (displays all right in the Spellbook, and in Gamemode the Icon for the Selected Spell), but the Icon in the upper right corner (for active Effects) still shows the ScriptEffect-Icon. Couldn't you change Icons of every Script-Effect in the Effect-List, too?
Because I think this is due to displaying the Effects, not the spells.


Additionally, I tried setting the Icons of several Spell with a Mod, but it didn't work. Maybe the Error is on my side*, so is there any way to enable some Debug-Output?

*I don't like dependencies, so I chose a slightly altered way. Would be easier btw. if the Variables would be hold by a Quest.

The exact code that is causing you problems is this:

if ((currentSpell != GetPlayerSpell) || (refresh))	set currentSpell to GetPlayerSpell	if (refresh)		SelectPlayerSpell CSIDummySpell		SelectPlayerSpell currentSpell		set refresh to 0	endif...

There is the assumption that GetPlayerSpell will actually return a valid spell reference. I suppose I could add a check that currentSpell == 0, and if so, set the player spell to DefaultPlayerSpell.

edit: found a way to avoid the issue.



Maybe this is what Phosi was talking about... I thought he meant the icon in the lower left :facepalm:
The problem with changing the active effect icons is that spells share them - two or more spells with the same effect results in one icon, and the timer displayed is for the most recent active effect. So you end up with your HUD giving you incorrect information about the status of your spells. The feature only existed in the 1st version as one of the annoying side effects/bugs of messing with magic effect settings, which the new version no longer does.

That said, it might be possible to have at least script effects show unique icons. Back to the CS...



I don't thinks it's possible without dependencies, unless you copy the entire contents of the .esm into your mod (which you are free to do so). But then, as I explained in an earlier post, you will have conflicts if you use your mod with CSI or any other mod that does the same.

I'm curious what your altered way is.

	RunScriptLine "set LPUSfEQuInitialization.rCustomSpellIcons to CustomSpellIcons"	set lIndex to ( GetSourceModIndex rCustomSpellIcons )	set sTemp to ( GetNthModName lIndex )	set rCustomSpellIconsReset to ( GetFormFromMod $sTemp "001C82" )	set rCustomSpellIconsSet to ( GetFormFromMod $sTemp "0015AD" )	sv_Destruct sTemp	if Eval ( IsFormValid rCustomSpellIconsSet ) && ( !bCustomSpellIcons )		if ( IsReference rCustomSpellIconsSet )	;I put this one in because I used the wrong FormID first ^^			if ( rCustomSpellIconsSet.HasVariable "SpellRef" ) && ( rCustomSpellIconsSet.HasVariable "IconPath" )				PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Custom Spell Icons found."				set bCustomSpellIcons to 1				let aMagicItems := ( Call LPUSfEFuncGetAllMagicItems )				PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Start, MagicEffectCount: " + ( ToString ( ar_Size aMagicItems ) )				ForEach aIterator <- aMagicItems					let rMagicItem := ( aIterator["Value"] )					PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " MagicItem: " + ( GetName rMagicItem ) + " (" + ( GetFormIDString rMagicItem ) + ")"					set lIndex to -1					While ( ( lIndex += 1 ) < ( GetMagicItemEffectCount rMagicItem ) )						if ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEAbsorbScript ) || ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEDrainScript ) || ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEFortifyScript )							Break						endif					Loop					if ( lIndex == ( GetMagicItemEffectCount rMagicItem ) )						PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " MagicItem " + ( GetName rMagicItem ) + " (" + ( GetFormIDString rMagicItem ) + ") doesn't have an Unarmored ME-Script."						Continue					endif					if ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEAbsorbScript )						set rMagicEffect to ( MagicEffectFromChars ABSK )					elseif ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEDrainScript )						set rMagicEffect to ( MagicEffectFromChars DRSK )					elseif ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEFortifyScript )						set rMagicEffect to ( MagicEffectFromChars FOSK )					endif					set sIconPath to ( GetIconPath rMagicEffect )					PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " IconPath: " + sIconPath					rCustomSpellIconsSet.RunScriptLine "set SpellRef to %i", rMagicItem, 1		;These are the lines where I'm not sure if they're working					rCustomSpellIconsSet.RunScriptLine "set IconPath to %.0f", sIconPath, 1		;These are the lines where I'm not sure if they're working					rCustomSpellIconsSet.Activate2 Player, 1				Loop				sv_Destruct sIconPath				PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Finished, MagicEffectCount: " + ( ToString ( ar_Size aMagicItems ) )			else				PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Variables not found. Reference: " + ( rCustomSpellIconsSet.GetName ) + " (" + ( rCustomSpellIconsSet.GetFormIDString ) + ")"				set bCustomSpellIcons to 0			endif		else			PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Is not a Reference: " + ( GetName rCustomSpellIconsSet ) + " (" + ( GetFormIDString rCustomSpellIconsSet ) + ")"			set bCustomSpellIcons to 0		endif	endif

So in fact I just need an output-function for the values of SpellRef & IconPath.
Think I'll do this for myself, shouldn't be that difficult.

Seems like a lot of work just to avoid the file requiring a dependency to load, even though it still needs the esm to actually do anything. Though I guess it's a good way to include the feature as an option without needing extra .esp patches. If you can wait until OBSE v0018 I'm going to add actual functions to make it easier to work with.

Only the first 7 lines are required to remove the dependency. Not that much of work I think. At least for me, because I already did this for X-Skills so this was basically Copy & Paste.
Setting the Variables is a bit difficult, though.
The way I tried it here didn't work by the way.

Currently the main problem I have is, that I already use a UserFunction and therefore can't reference it directly in RunScriptLine.
Will try out using a Quest-Variable next.

Oh, and the ForEach-Block is only required because it's impossible to use let within RunScriptLine and therefore to use Arrays.

Here's my (adjusted & currently untested) Function-Code:

scn LPUSfEFuncSetSpellIconslong lIndexref rCustomSpellIconsSetref rMagicEffectref rMagicItemref rScriptarray_var aIteratorarray_var aMagicItemsBegin Function { rCustomSpellIconsSet }	set rScript to LPUSfEFuncSetSpellIcons	if ( IsFormValid rCustomSpellIconsSet )		PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Custom Spell Icons found."		SetFunctionValue 1		let aMagicItems := ( Call LPUSfEFuncGetAllMagicItems )		PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Start, MagicEffectCount: " + ( ToString ( ar_Size aMagicItems ) )		ForEach aIterator <- aMagicItems			let LPUSfEQuInitialization.rSpell := rMagicItem := ( aIterator["Value"] )			PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " MagicItem: " + ( GetName rMagicItem ) + " (" + ( GetFormIDString rMagicItem ) + ")"			set lIndex to -1			While ( ( lIndex += 1 ) < ( GetMagicItemEffectCount rMagicItem ) )				if ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEAbsorbScript ) || ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEDrainScript ) || ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEFortifyScript )					Break				endif			Loop			if ( lIndex == ( GetMagicItemEffectCount rMagicItem ) )				PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " MagicItem " + ( GetName rMagicItem ) + " (" + ( GetFormIDString rMagicItem ) + ") doesn't have an Unarmored ME-Script."				Continue			endif			if ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEAbsorbScript )				set rMagicEffect to ( MagicEffectFromChars ABSK )			elseif ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEDrainScript )				set rMagicEffect to ( MagicEffectFromChars DRSK )			elseif ( ( GetNthEffectItemScript rMagicItem, lIndex ) == LPUSfEMEFortifyScript )				set rMagicEffect to ( MagicEffectFromChars FOSK )			endif			set LPUSfEQuInitialization.sTemp to ( GetIconPath rMagicEffect )			PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " IconPath: " + LPUSfEQuInitialization.sTemp			rCustomSpellIconsSet.RunScriptLine "set SpellRef to LPUSfEQuInitialization.rSpell", 1			rCustomSpellIconsSet.RunScriptLine "set IconPath to LPUSfEQuInitialization.sTemp", 1			rCustomSpellIconsSet.Activate2 Player, 1		Loop		sv_Destruct LPUSfEQuInitialization.sTemp		PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Finished, MagicEffectCount: " + ( ToString ( ar_Size aMagicItems ) )	else		PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Custom Spell Icons not found."		SetFunctionValue 0	endifEnd

And that's the code calling it:

;Scriptname & Variables hereBegin Gamemode;Some other stuff here	RunScriptLine "set LPUSfEQuInitialization.rCustomSpellIcons to CustomSpellIcons"	set lIndex to ( GetSourceModIndex rCustomSpellIcons )	set sTemp to ( GetNthModName lIndex )	set rCustomSpellIconsReset to ( GetFormFromMod $sTemp "001C82" )	set rCustomSpellIconsSet to ( GetFormFromMod $sTemp "0015AD" )	sv_Destruct sTemp	if Eval ( IsFormValid rCustomSpellIconsSet ) && ( !bCustomSpellIcons )		let bCustomSpellIcons := ( Call LPUSfEFuncSetSpellIcons rCustomSpellIconsSet )		if ( bCustomSpellIcons )			PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Custom Spell Icons Initialized."		else			PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Custom Spell Icons couldn't be Initialized."		endif	endif	if ( bAllMIDummyEffectsHidden ) && ( bCustomSpellIcons )		let bAllMIDummyEffectsHidden := ( Call LPUSfEFuncAllMIAddDummyEffects )		PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Added Dummy Effects."		Call LPUSfEFuncSetSpellIcons rCustomSpellIconsSet	endifEndBegin Menumode	if Eval ( !( Menumode 1022 ) ) && ( !( Menumode 1037 ) ) || ( !bCustomSpellIcons ) || ( bAllMIDummyEffectsHidden )	;Magic / Spell Purchase		Return	endif	let bAllMIDummyEffectsHidden := ( Call LPUSfEFuncAllMIRemoveDummyEffects )	PrintD ( ASCIIToChar 2 ) + "LPUSfE (" + ( GetFormIDString rScript ) + "):" + ( ASCIIToChar 3 ) + " Removed Dummy Effects."	Call LPUSfEFuncSetSpellIcons rCustomSpellIconsSetEnd

PS:
Just tried it: the CSI.esm doesn't need to be dependent of the Oblivion.esm.
Removing it from the MasterList fastens loading in CS drastically (and doesn't create any problems ingame).




Edit:
New Code works now. :celebration:

One request, though:
Can you please also update the spells in the Spell purchase Menu (Menumode 1037).

I fixed your issue with the dummy spell showing up, you can get the new .esm from tesnexus.



That's actually why I had my dummy spell instead of just using one from oblivion.esm, but at some point I loaded a different mod, reloaded CSI, and didn't remove oblivion.esm as a master.

'

Heh, never thought about that one. Shouldn't be too hard to do.

...or not. Unless I'm missing something, there doesn't seem to be a way to get a list of all the spells an actor has. You can get the leveled spells, and you can use HasSpell, but there's no GetNthSpell like there is for the player. Without the list of spells I can't properly set the icons in the merchant menu.

Actually, there is. And it's just reference.GetNthSpell (same for GetSpellCount), originally it was GetNthPlayerSpell but later on it became possible to use just GetNthSpell on any reference.

When you call GetNthSpell without a reference it will default to the player.

In the OBSE documentation it's still listed as an alias for GetNthPlayerSpell. I guess it must be out of date, there have been a couple other functions that aren't listed. Good to hear though

Yea it's a bit outdated, but I'm positive it works, I use it in my Spell Renamer mod without problems.

Ah. Alas, I did mean in the lower left, sorry

It's ok, though, V1 still works fine, it's a lovely mod