I've spent the past few days struggling with Papyrus. I'm trying to make a script that ties the transformations of a werewolf to the moon, and mostly failing, and I've managed to track down the reason, using debug functions, to the Global Variables I'm referencing in the script (it's a quest script), in this case PlayerIsWerewolf, GameHour, and GameDaysPassed; No matter what I do or how I change the script, all of the global variables return as 0. No matter what I do, how I change the script, or what I do with the properties, they won't return as anything other than zero, as evidenced by a notification I put in the script that returns the value of the property recording GameHour ( TimeOfDay ) every second; it doesn't change at all.

I'm positive the script is actually running, since the notification always comes in, and otherwise it seems to be running as intended, excluding of course everything that's dependent on the global variables.

If anyone has found a way to get a script to return the actual value of a global variable, I'd very much appreciate your help. I looked through the wiki, double checked my syntax, everything I could think of, and still its not working.

PS: Before you ask, I configured the script's properties in the property window to reference the correct variables, so that's not the problem, though I initially thought it was.

You definitely need to do that, although Auto fill will do that for you.

To access a Global, you need to define it:

GlobalVariable Property ImsixyAndIKnowIt auto

Assuming 'ImsixyAndIKnowIt' is exists (vanilla or user-made global) it will be populated for the script.

^ I did both of those. If nothing else is wrong there, then I'm guessing that means that there's something wrong with the way I referenced the global variables in the actual script. Sorry if I phrased it wrong, but I did auto fill it in the properties menu.

Basically I put

TimeOfDay == Gamehour.Getvalue()

and then as the debug notification, some time later in the script.

debug.notification(TimeOfDay)


If it was working properly, I imagine TimeOfDay would be returning as well, whatever time it is.

I was looking at some of the Bethesda scripts, and I noticed that instead of Global.Getvalue()

they used Global.value

Would that be what I'm missing?

It would be worth trying, although looking at the http://www.creationkit.com/GlobalVariable_Script documentation you'll be able to see that "value" is a float property (meaning it can be read by other scripts), whereas the function "GetValue" is simply a function that returns the value stored in the property "value". The two methods should work essentially identically.

Cipscis

Just tried it. Not working. I think maybe I'll just create an extremely script solely to return a random global value, get that working, and figure out what's wrong.

ScriptName PlayingWithGlobalsGlobalVariable Property GameHour autoEvent OnUpdate()if GameHour.Value != 0debug.notification("Global Has Returned as Non-zero value.")elsedebug.notification("Global Has Returned as zero.")endifend

The papyrus fragment in the PlayingWithGlobals quest is simply

RegisterForUpdate(1)

Okay, why isn't it letting me make a Papyrus fragment?

ScriptName PlayingWithGlobals extends Quest

Heh, yeah figured that one out when it refused to compile "registerForUpdate", on the plus side, it might actually be working.

And it WORKS!!! Now to figure out what it was in my script that caused things to go wrong...

Edit: I noticed something perculiar: For some reason, every so often, it would spam me with a zero in the notification area, despite the fact that this script was literally the only one running on that quest and the only thing I changed.

Damnit damnit damnit damnit. As soon as I waited, everything exploded. It just derps around at approximately 17 (GameHour.value) that is. Methinks there might be some bugs that Bethesda just didn't care about.

do you save the GameHour.value to a local variable ?

Nope, I didn't, and I imagine that was the issue the original script had, wasn't it?

Anyhow, it actually seems to be working, except that its not returning the (It's after 8) notification I want it to.

can you post your current code here Gonna test it in the CK myself.

How odd. So Global Values can be read/written when extending from a Quest but not when extending from ActiveMagicEffect?

Sure thing...Hmm Let's see

It was

Scriptname cohMoonPhaseScript extends Quest  GlobalVariable Property GameHour autoEvent OnInit()RegisterForUpdate(1)EndEventEvent OnUpdate()if GameHour.Value >= 20debug.notification("It's after eight")elsedebug.notification(GameHour.Value)endifEndEvent

I'm not sure if the is the fact that its spamming notifications so fast that its bogging down the script, but something's not working the way it should. Then again, maybe I should have the time of day return every 5 seconds instead of every one second.

Ah, I see my problem. I didn't know I had to go over to Miscellaneous and create a Global variable in the "Global" section. So I was referencing a Global that didn't exist.

Scriptname WarewolfTransformation extends Quest Hidden{Transform god damit !!!}import debugGlobalVariable Property GameHour autoEvent OnInit()  debug.notification("Updating register !!!")  RegisterForUpdate(5)EndEventEvent OnUpdate()  if GameHour.Value >= 20	debug.notification("It's after eight")  else	debug.notification("its = " + GameHour.Value)  endifEndEvent

works like a charm. I noticed it notified me two times that the script got registered so it means the "start game enabled" counts like an event Oninit()
What might be the case is that I First created the quest named GSQ01 priority 60 event none start game enabled type none then OK
After that I opened it and added a new script >> code that I posted.
Then I saved and compiled , cliked OK.
Opened the quest went to scripts and choosen my scipt properties. Now I saw GlobalHour as an unknown property so I clicked auto-fill and saved.
After this is started to work, didnt work before I used the auto-fill.

I brought this up in testing, here's the explanation I was given (SmkViper is a developer):

Cipscis

^^ Die by sword: Still thinks its whatever time the script started at, which in my case is never between eight and midnight.

Edit: Or rather, that's what the debug notification's saying, though considering its OnUpdate(), it's probably taking each and every hour into accommodation. Perhaps it should send the message if and only if its in the correct time interval?

Btw, is there any reliable way to check what the value ACTUALLY is?

Well I was sitting there from 3 pm to 8 pm and it notified me every 5 sec about the current time and once it hit 8 pm to 11:59pm it said "It's after eight"
You can see the actual value in Miscelanous->Global->GlobalHour

Well that's good. For some reason I keep getting random spams of the current time in float form with no "It's (x) time", though that may be an artifact of another script that I made in this plugin.

Well, it looks like things are working, though now that I've moved onto the next step I'm getting a similar problem: When I try to set a global value when the conditions (in this case hours between 8 PM and 9 AM) clear, in this case a custom global, "cohTransformationsAllowed", it doesn't work. I've verified this with the console command GetGlobalValue...

Do I need to import the global value script functions in order to Set global values?

Edit: Herpaderp, I may have forgotten to define cohTransformationsAllowed in the properties menu.

Here's the script as of now...I'm still getting a mysterious spam of the game hour function at intervals of one second though...Oh herpaderp, forgot to disable the other .esp I was using...And yet the clockspam continues.

Scriptname cohMoonPhaseScript extends Quest Hidden{Not Done Yet}import debugGlobalVariable Property cohTransformationsAllowed autoGlobalVariable Property GameHour autoEvent OnInit()  RegisterForUpdate(5)EndEventEvent OnUpdate()  if GameHour.Value >= 20 || GameHour.Value < 5cohTransformationsAllowed.SetValue(1)  elsecohTransformationsAllowed.SetValue(0)  endif  if cohTransformationsAllowed.Value =http://forums.bethsoft.com/topic/1345214-getting-a-script-to-correctly-return-a-global-value/= 1debug.notification("Transformations Are Allowed!")endifEndEvent

Scriptname WerewolfTransformation extends Quest Hidden{Controls the Timing for transformation.}import debugimport Mathint  property cohCanTransform autoSpell property WerewolfChange autoGlobalVariable Property GameHour autoGlobalVariable Property GameDaysPassed autoGlobalVariable Property PlayerIsWerewolf autoGlobalVariable Property PlayerWerewolfShiftbacktime autoMagicEffect Property WerewolfChangeEffect autoEvent OnInit()  debug.notification("Updating register - Warewolf active !!!")  RegisterForUpdate(20)EndEventEvent OnUpdate(); Determining Moon Phase Below...Not yet implimented.  int timeOfDay = GameHour.GetValueint()  int DaysPassed = GameDaysPassed.GetValueint(); Ignore PhaseDay, not functioning in this iteration of the script.if timeOfDay >= 20 || timeOfDay <= 6  debug.notification("It's after eight")  cohCanTransform = 1else  debug.notification("its = " + timeOfDay + " o`clock")  cohCanTransform = 0endifif PlayerIsWerewolf.GetValue() == 1  debug.notification("werewolf")else  debug.notification("no werewolf")endifif game.getplayer().HasMagicEffect(WerewolfChangeEffect) == 1  debug.notification("werewolf effect")else  debug.notification("no werewolf effect")endifif PlayerIsWerewolf.GetValue() == 1 && cohCanTransform == 1 && game.getplayer().HasMagicEffect(WerewolfChangeEffect) == 0  debug.notification("We change into a werewolf now !!!!!")  PlayerWerewolfShiftbacktime.SetValue(10000)  WerewolfChange.Cast(Game.GetPlayer(), Game.GetPlayer())elseif game.getplayer().HasMagicEffect(WerewolfChangeEffect) == 1 && cohCanTransform == 0  PlayerWerewolfShiftbacktime.SetValue(1)  game.getplayer().DispelSpell(WerewolfChange)  debug.notification("We change back into our orginal race now !!!!!")else  debug.notification("Buisness as usual  !!!!!")endifEndEvent

Everything works except when it goes into transformation time the warewolf change dosnt happen.
After looking into Spell category I found WerewolfChange (power) and WereWolfchangeFX (spell) so the syntax might be wrong here.

WerewolfChange.Cast(Game.GetPlayer(), Game.GetPlayer())

Yeah, I think it would be better to start the Playerwerewolf transformation quest line and piggyback on the 400 odd line long script from Bethesda that I'm going to have to look through and modify.

Lmao it works

WerewolfChange.Cast(Game.GetPlayer(), Game.GetPlayer())

Is the way to go

I fixed the code 2 post above Copy/paste into your quest script and test it Hilarious when I transformed next to the jarl in Dragonsreach.
And heres a clean (no debug) code

Scriptname WerewolfTransformation extends Quest Hidden{Controls the Timing for transformation.}int  property cohCanTransform autoSpell property WerewolfChange autoGlobalVariable Property GameHour autoGlobalVariable Property GameDaysPassed autoGlobalVariable Property PlayerIsWerewolf autoGlobalVariable Property PlayerWerewolfShiftbacktime autoMagicEffect Property WerewolfChangeEffect autoEvent OnInit()  RegisterForUpdate(20)EndEventEvent OnUpdate(); Determining Moon Phase Below...Not yet implimented.  int timeOfDay = GameHour.GetValueint()  int DaysPassed = GameDaysPassed.GetValueint(); Ignore PhaseDay, not functioning in this iteration of the script.if timeOfDay >= 20 || timeOfDay <= 6  cohCanTransform = 1else  cohCanTransform = 0endifif PlayerIsWerewolf.GetValue() == 1 && cohCanTransform == 1 && game.getplayer().HasMagicEffect(WerewolfChangeEffect) == 0  PlayerWerewolfShiftbacktime.SetValue(10000)  WerewolfChange.Cast(Game.GetPlayer(), Game.GetPlayer())elseif game.getplayer().HasMagicEffect(WerewolfChangeEffect) == 1 && cohCanTransform == 0  PlayerWerewolfShiftbacktime.SetValue(1)  game.getplayer().DispelSpell(WerewolfChange)endifEndEvent

What property do I define "werewolf' (the magic effect) as?


Edit: Looks like my scripting engine or something is ACTUALLY broken...That script works for you? For me it doesn't do anything at all.