Actor property PlayerRef autoBool bStopLoop = falseEvent OnEffectStart(Actor akTarget, Actor akCaster);Float CurrentPercent = PlayerRef.GetActorValuePercentage("Magikca")Float BaseMag = PlayerRef.GetBaseActorValue("Magicka")Float CurrentMag = PlayerRef.GetActorValue("Magicka")    If akCaster == PlayerRef        While bStopLoop == false            debug.notification("While loop has started.")            If CurrentMag == BaseMag                akCaster.InterruptCast()                bStopLoop = true            Endif        EndWhile    EndifEndEvent

Notification keeps playing regardless. The loop is supposed to stop when the magicka reaches maximum. I've already tried changing the loop to 'PlayerRef.GetActorValuePercentage("Magicka") < 1.0'

As an additional side effect, it keeps playing even when the effect is gone(the casting stopped.)

The second statement works as intended at least for interruptCast.

I made a Convert Stamina to Magicka type spell, but the stamina keeps draining even when the magicka is full, so I'm trying to stop the effect when the magicka is full.

The variable CurrentMag is only obtained once at EffectStart, it is never updated during the While Loop. Therefore CurrentMag will never equal BaseMag. Moving the position of CurrentMag, would obtain the new value each loop, but would this have performance issues

Actor property PlayerRef autoBool bStopLoop = falseEvent OnEffectStart(Actor akTarget, Actor akCaster);Float CurrentPercent = PlayerRef.GetActorValuePercentage("Magikca")Float BaseMag = PlayerRef.GetBaseActorValue("Magicka")    If akCaster == PlayerRef        While bStopLoop == false           Float CurrentMag = PlayerRef.GetActorValue("Magicka")            debug.notification("While loop has started.")            If CurrentMag == BaseMag                akCaster.InterruptCast()                bStopLoop = true            Endif        EndWhile    EndifEndEvent

I was about to post the same as heilghast. However, I am a bit puzzled by the statement that InterrupCast is being called nonetheless. Perhaps the script instance is being reset frequently and causing bStopLoop to reset to false before it is evaluated? I've encountered issues caused by variables being reset in the middle of running a function and the cause was the script instance being reset. You could try moving the bStopLoop declaration into the event or use a variable that is stored outside of this script (global variable or another script).

Is this a Fire and Forget or a concentration spell?

As i have a fire and forget spell which converts health to magicka for a duration of 1 minute, but when magicka is full, i use a condition on the spell to stop the effect. However it does restart, if magicka drops below maximum.

It's concentration, I was also trying to emulate the concentration healing spell, ya know, a heal spell for health and a heal spell for magicka.

Learned something new.. the position of declarations matter in an event o_o. I thought as long as it's declared it doesn't matter where its placed.

Performance issues.. How do I avoid that?

@MrJack - further testing shows interruptCast is not calling as I thought it was. IIRC it should stop the casting animation(it doesn't). But the effects that play on the character end when magicka is full. Well, that's part of what I want.

It's not where the variable is declared that matters so much as where the value gets assigned to it. For instance...

Actor property PlayerRef autoBool bStopLoop = falseEvent OnEffectStart(Actor akTarget, Actor akCaster);Float CurrentPercent = PlayerRef.GetActorValuePercentage("Magikca")Float BaseMag = PlayerRef.GetBaseActorValue("Magicka")Float CurrentMag    If akCaster == PlayerRef        While bStopLoop == false            CurrentMag = PlayerRef.GetActorValue("Magicka")            debug.notification("While loop has started.")            If CurrentMag == BaseMag                akCaster.InterruptCast()                bStopLoop = true            Endif        EndWhile    EndifEndEvent

...has the declaration of CurrentMag outside the loop, but the assignment in the loop.

Personally I prefer to put all declarations at the top of the code for readability, and in many languages that's a requirement, but my understanding, like yours, is that they can be declared pretty much anywhere.