So far, I've been terrible at writing lore for a game I'm making. What did Bethesda do to write such good lore? What's their secret?

Many imaginative people have contributed many wonderful ideas for 21 years.

Practice and a large team of experienced and proven writers. Developing good plots and characters isn't a gift that people are born with, there'll be many poor ones before you finally create a gem.