Greetings! If anyone out there is at all familiar with scripting then perhaps you could create a mod that simply removes the "stolen" tag from any item you steal that no one notices?

For instance, if you go to steal an apple or a helmet, and do so undetected, that item should have its ownership cleared. But only if no one saw the act!

:drool:

Your help would be greatly appreciated

Well, so far all I've managed to locate at http://cs.elderscrolls.com/constwiki/ was the beginning of the script:

Begin OnAdd

If anyone else can help, please do. I'm new to scripting and don't think I can figure it out alone.

Well, I can give you some tentative advice, though I don't know exactly how to do what you want.

I believe OnAdd is for a script attached to a particular object. In order to have a script trigger when any object is added to the players inventory, i think OnActivate is what you want, but I've never used that so I'm not sure.

Some tips: see GetOwner (requires OBSE), SetOwnership, and IsActorDetected.

Thank you, SetOwnership was the command I was going nuts trying to remember.

I tried making my own little script that simply changes ownership of any item you acquire, but SetOwnership/Player.SetOwnership didn't seem to do it. :brokencomputer:

I don't think I'm cut out for scripting. :banghead:

http://planetelderscrolls.gamespy.com/View.php?view=OblivionMods.Detail&id=1847

Contains a barrel that removes the stolen tag from any items, I'd just reverse engineer this

I'm curious as to how you plan on fencing items for the Thieves Guild if nothing is tagged stolen?

I know how to edit scripts, I can bypass that easily. I don't enjoy the Thieves' Guild anyway. I know this game inside and out, so I'm not missing out on anything even if I don't make this Thieves' Guild-friendly.

Not sure from what you've written here whether you've done this already, but you need to call SetOwnership on the reference of the object you want to change. ie.
myStolenItemRef.SetOwnership player

I′ll give you a complete script - you can make it more advanced if you want then. You′ll put this as a new quest script, so that it runs all the time (it′s not "quest", it′s just that quest script are global scripts that run all the time).

I′ll edit this post in a minute, with the script.


EDIT: Here′s a script that sets the ownership of the item you activate to player, if player is undetected. The script works by setting the ownership BEFORE the game moves the item into your inventory.

I set some basic checks for a valid target, but I don′t know what happens if you target a wall and press activate key. Probably nothing, and the ownership call is inside testExpr obse function that suppresses script errors, so the script shouldn′t crash even with unvalid targets.

But I take no responsibility - if you want you can install specific checks for valid targed, by using Obse′s getObjectType and check the target′s item type - you′ll just have type many alternative valid type codes.




EDIT: Click the reply button - when it quotes my post, the script indentation shows correctly and it′s easier to read.

EDIT2: It requires Obse, BTW.

Sounds good, thank you Skycaptain. I'll give this a shot.

Whenever I try to save the script I get an error: Script command "fquestdelaytime" not found.

change
fQuestDelayTime
to
float fQuestDelayTime

Thank you crysallus, that allowed me to save. Now, I attached it to a quest through the "Script" option with all default settings to the quest, but it isn't working ingame. Is there some specific alteration I need to the quest? I've tried setting the Quest Priority to 0, 5 & 90 but it didn't help.

Did you set the quest to "start game enabled"?

Yes, that is enabled by default.

"itemRef" is typoed as "itemRer" in one of the if statements. This may have compiled, treating it as a literal string. That would cause the script to fail silently, because it never passes that if.

Yes, I changed that too. :banghead:

It wouldn't let me save when it was ItemRer

hit the tilde key in game and type into the console

sqv questname

and replace questname with the name of the quest you attached the script to.

This should show you whether the quest script is even running or not to start with.

Note however that quest scripts take a few seconds to start after loading your game, so give it at least 5 seconds or so.

It says that the quest is running, with priority 0. Could the problem be within the script?

I'm not sure what IsActorDetected returns if you're not even attempting to sneak. Make sure you're in sneak mode when you try this, even though you're alone in the cell.

I stole items while sneaking or standing, with or without other NPCs in the cell, detected or not, and the item is still flagged as stolen in my inventory. :facepalm:

Insert some debug statements in the script, to see it excecutes properly.

For example, insert

printc "before setOwner"

printc "after setOwner"


before and after the ownership setting lines. You probably got the idea - insert as many prints, in different parts, as you like. You can see them print to the console then - then you know if some if-statement didn′t pass etc.


It′s POSSIBLE that the whole idea doesn′t work - even though I know the item gets added to your inventory only the next frame after the OnControlDown fires, it′s possible that the game reads the ownership during that frame already (and thus the script is inherently too late) - and then adds a COPY of that item, with THAT ownership, to your inventory.

We′ll know that once we know if the script actually does what it′s supposed to do (-> insert print commands). If it does, and it still fails, then it simply cannot be done like this. Then it requires finding the copy of the item you activated in your inventory, by inventory looping, and setting the flag there. I didn′t do this, even though I know how to, cause it′s simply much longer script to write and seemed unnecessary here.

Could you give me an example of where to insert "printc"? Before & after "TestExpr(itemRef.SetOwnership)"?

yeah, like:

printc "I′m before SetOwnership"
"TestExpr(itemRef.SetOwnership)"
printc "I′m after SetOwnership"


This way the script "talks to you" via console, you can make it tell you what it′s doing. If some message DOESN′T print, when it should, you′ll know the if condition before it didn′t pass.

Like:

printc "before if itemref"
if(itemRef != 0)
printc "after if itemref"

I keep getting an error: "Missing parameter format string."