Now that's something I may be able work off of, thanks.

Okay: Here's the thing. It was basically some kind of funk-up at 4shared.

I had uploaded a file with the same name in the past, and it somehow linked the download to the old one...

So I decided just to upload a new archived version, with the new ESP inside. Also updated OP download link.

http://www.4shared.com/file/102160368/4ada1292/linwebetadoom2.html

Testing results for lin_we_beta_new.esp (04-28-2009 01:55):

'Initial configuration completed' messagebox no longer displayed after reloading a save. However, I'm still getting a crash in d3d8.dll when loading a previous save game where MUWE was active - whether it's during the same session but with a different save game than the current game, or after exiting MW and reloading any MUWE save.

Noticed that the underwater fade from black effect is not present (or not occurring) in this version.

All saves used for testing were created with this new version in order to not complicate things.

Heck yeah, I have an acronym now. :celebration:

Yeah, I removed the fade effect as it was impossible to make work how I wanted. And will become irrelevant once peachykeen finishes his fade-to-black shader, anyways. The effect will still be in there, just only when the water is actually darkened, and will be configured according to the setting the player uses. Morrowind's fade-functions do not except variables, so this was not possible before without a tremendously long script. Which wouldn't have been worth the effort or slowdown, imo.

As for the save-game issue, I have not yet been able to reproduce it for some reason. Could be the newer versions of MGE as I think I'm still using revision 107.

I'll try out the newest revision later and see if that is what is causing this to happen for you.

Thanks for testing Tetchy! :hugs:

Yes, I am sadly still crashing as well, using rev 110.

Okay, I can now confirm this issue. And it does it with rev 107 too, so it must be bug in my script that must squashed with my mighty daedric hammer of debugeration. :brokencomputer:

Thanks for finding this, tronvillain! Though, of course it would of been better if there was no bug to be found in the first place.

This issue with crashing the game is neither MGE, nor MWSE bug. It's bug in 'LIN_Mystical_WE' script with 'lastid' variable which is used for string pointer that is used between game sessions, but is not updated.

Simply you can't build a string with xStringBuild or xFileReadString and use it after reloading game without re[building|loading] this string, because pointer stored in this variable is no longer valid (and it's not zeroed because local variables are also saved to savegame).

Lines containing following instruction cause that game crash, because 'lastid' variable is not NULL and points to invalid address after loading the game:

	pcref->xRemoveSpell lastid

You need either store strings to a file, or rebuild them from numerical variables (I saw you build your strings from numbers, so the latter solution may be preferred).


EDIT: fixed some typos

Thanks kryzmar. Gonna work on fixing this and hopefully then this will be bug free enough to start adding new features! ( And probably create more bugs in the process. )

A question for anyone that knows... are there any pros or cons to doing one over the other? :blink:

Edit: Actually I just realized that when peachy finishes the new fade-to-black shader this will become entirely irrelevant anyways. But I'm still going to fix it for the learning experience.

file:
????pros:
????????- exact string is saved and loaded
????cons:
????????- slow
????????- every time the string is changing it must be rewritten to file
????????- if you load another savegame, saved string may be invalid

short, long (but not pointer), float variable:
????pros:
????????- fast
????????- takes only 2 or 4 bytes
????cons:
????????- only strings that are created from a dictionary or differ only in numerical part can be processed this way

EDIT:
I haven't anolyzed all the script code to know why two spells are removed, but changing for example this:

set lastid to nightidset NightDarkness to LIN_NightDarknesssetx nightid to xStringBuild "LIN_DWN_%d" NightDarkness

to that:

set prevNightDark to NightDarknessset NightDarkness to LIN_NightDarknesssetx nightid to xStringBuild "LIN_DWN_%d" NightDarknesssetx lastid to xStringBuild "LIN_DWN_%d" prevNightDark

would solve this problem.
Where prevNightDark, prevHalfDark, and prevStormDark (at other parts of script not listed here) would be new local variables.

EDIT2:
Or to optimize it a bit:

long templong lastidlong thisid...setx temp to xStringBuild "LIN_DWN_%%d"...setx thisid to xStringBuild temp NightDarknesssetx lastid to xStringBuild temp prevNightDark...setx thisid to xStringBuild temp HalfDarknesssetx lastid to xStringBuild temp prevHalfDark... setx thisid to xStringBuild temp StormDarknesssetx lastid to xStringBuild temp prevStormDark

Note that second '%' in first xStringBuild is required to get it to work properly, and you changed 'nightid', 'halfid', and 'stormid' at xAddSpell and xRemoveSpell to 'thisid'.

Thanks krzymar!

The reason for the two spells being removed is if there is a change in conditions the previous spell can still be in-effect.
I did this so that the spells wouldn't start stacking, which created.. what did tetchy call it, oh... "total perpetual darkness".

@Linora
This is to answer your question from the MGE thread regarding the error report - figured it'd be more appropriate to post here.

When you get an app error dialog, select the 'click here' hyperlink at the bottom of that window to get the 'Error signature' info, then from that window select again 'click here' to bring up the 'Error Report Contents' which will show the 'Exception Information' along with info about everything running in memory at the time of the crash.

I just manually typed the beginning info from that report into the MGE thread post, but if you're using winXP you can also find details of the report to copy & paste by searching for DrWtsn32.log - it's usually located in C:\Documents and Settings\All Users\Application Data\Microsoft\Dr Watson.

You'll notice that the DrWtsn32.log file is formatted differently than what the Error window shows. And the most recent crash info gets appended to the bottom of the log, so you'll want to look at the end of the file.

Okay, I've fixed up the script with kryzmar's bug-fix and optimization, and from my quick tests it loads correctly now.

http://www.4shared.com/file/102613268/f6883be3/muwebeta.html, archived with all files included. If this lives freely in the wild without bugs for a few days, I may share it as it is on PES, until peachy finishes the new shaders required to add the scalable blur, superior fade-to-black and water-dry-out effects, there's not much more to do on this right now.
( Yay, I can work on my Situational Surrender mod again! )

@ Tetchy
Thanks! Is there a doctor in the house? Say hello to Dr.Watson. :rofl:

I just downloaded it on my laptop, and looked at it with text editor. I can't test it in game right now, I will when I'm back home, but it won't work as expected.

The prevStormDark, prevHalfDark, prevNightDark aren't initialized anywhere, they should be like:

set prevNightDark to NightDarknessset NightDarkness to LIN_NightDarkness

, etc. (a line before 'set NightDarkness' is missing) for each of mentioned variables. Currently they have always got value of 0, so the darkness spells will be stacking.

Also no longer used variables can be removed or commented out from file, so the code and saves don't need to allocate additional space for them:

long stormidlong nightidlong halfid

BTW. My nick has wrong spelling in plugin - it should be krzymar, and not kryzmar. I don't care how it's written on forums, but in the published file it does matter.

:banghead: That's what I get for trying to fix something when I'm tired. :snoring:

For now on I must make sure to spell your name right on the forums too.

Okay, I've fixed the issues krzymar mentioned, and tested it out a for a few minutes. ( By using the console to set the gamehour while underwater. ) This time let's hope it works correctly!

http://www.4shared.com/file/102710083/25b467c0/muwebeta2.html

Testing results for muwebeta2:
All tests done against mge3.8_svn-rev0111

* Confirmed - able to reload a previous save between game sessions; no more crashes and initial config messagebox does not reappear (as expected).
* Verified - also works with old MUWE beta saves, but will get a warning message on load:Continuing to run will successfully load the save; re-saving will remove the warning message next time save is loaded.

* Confirmed - changes to underwater darkness levels properly progress during day/night/day transitions without stacking.
* Confirmed - proper underwater darkness level applied for weather types 3 - 9; 'Dark Waters' spell properly removed when surfacing in all cases.
* Confirmed - proper underwater darkness levels (night or weather) applied to and removed from interiors-as-exteriors.
* Confirmed - only underwater night darkness levels applied to and removed from true interiors (as expected - no weather effects).
* Confirmed - yurt interiors remain free of underwater effects.

I tried loading between exterior saves and interior saves (both true and acting as exteriors) where some of the saves were made while underwater and others above. Got a crash a couple times after loading a save in 'Mournhold, Temple Courtyard' and then loading a true interior save made while underwater - however it was not reproducible every time, and alternately crashed msvcrt.dll and d3d8.dll (both access violation errors). Could also be a problem with latest MGE betas that add MGE water effects to interiors and have nothing to do with MUWE (need to test this further). :shrug:

All in all, this one performs admirably Linora! :thumbsup: :thumbsup: :thumbsup:

Thanks yet again Tetchy! I'm thinking the problem you mention is related to MGE, as it would likely be more consistent if it was caused by me. Once those new shaders come in from peachy, I'll be able to add some of those suggestions you made in your earlier posts.

http://www.mediafire.com/?mtcmmyuehcy

Should do the trick. Fades out, but leaves the bars, items, and minimap. Set percent to the desired percent (0.5 for 50%).

YAY! Thank you peachy! ^_^

Now to I'm off script it in. :bolt:

I small update...

It could be a bit longer til the next version, since I'm taking my SAT on June 6th and need to crack down on my studying. So on the little bit of free-time I have I'll be able to work on this and other projects, but study > fun.

My final high school exams are in two weeks, so my own modding projects are pretty much on hold for now too. Good luck with your SAT and we'll see you later!

Thanks! And I wish you good luck on those finals! :deal:

Hi Linora: I encountered some problems using MUWE with the latest MGE SVN rev-0114, reported http://www.gamesas.com/bgsforums/index.php?s=&showtopic=985453&view=findpost&p=14300626. Not sure it crashes because of MGE or MUWE, it was working fine with the MGE SVN rev-0112, but I also had trouble with SVN rev. prior to 0111.

Apart from this, excellent mod! :thumbsup:

Linora must still be busy studying. I anxious to see what else she updates to this project.