[RELz] Companion Share & Recruit

Post » Fri Feb 18, 2011 9:27 pm

Oh wow, that's a neat little mod. Thanks Talkie.

Also, neat little mindscrew; The 3rd Type and The Talkie Toaster both contain 3 words that start with T.

The Triple Threat also has three words that start with T's, something your Companion Core Mods (RobCo Certified, Wasteland Whisperer, and Companion Share & Recruit) could be collectively called.

I dunno, I thought it was funny...
User avatar
Lexy Corpsey
 
Posts: 3448
Joined: Tue Jun 27, 2006 12:39 am

Post » Fri Feb 18, 2011 7:16 pm

If it's a basic companion that only uses AI packages, it should basically be a matter of CSR adding a script AI package to pick the lock, then clearing the scripted packed when done and then he will resume use of his built in AI.. right? I ran into some wonky stuff using Remote Control Companions PLUS's wait/follow, but that mod also includes a handy "clear scripted package" command.
I'm afraid it's not quite that simple. CSR looks for available NPCs in its "Party members" list, which an NPC is only on if they're under follow orders from CSR itself, and once the lockpick has finished it forces a follow package back on them. It also only looks for NPCs to heal in the party list and so on, the list system and shuffling NPCs between the various lists is basically the backbone of Companion Core and tied in to everything else, which makes integrating NPCs not managed by it a bit of a bugger.

T3T: What makes things even more confusing is SaidenStorm refers to me as 3T, so browsing the forums is an exercise in bafflement.
User avatar
Jake Easom
 
Posts: 3424
Joined: Sun Jul 29, 2007 4:33 am

Post » Sat Feb 19, 2011 2:17 am

In trying download and install the latest version - after three tries downloading I cannot get the zip to open - maybe something wrong with it.

Hmm - same with Impervious power armor too.

The latest RobCo was fine though.
User avatar
Roberto Gaeta
 
Posts: 3451
Joined: Tue Nov 06, 2007 2:23 am

Post » Sat Feb 19, 2011 7:35 am

That's kind of odd, perhaps the upload got interrupted or something. Either way, I needed to upload a new version sometime- the "Make yourself at home" package being Sandbox just didn't work right, NPCs dropped it after one action, then had it forced back on, then dropped it again, and repeated ad nauseam. I'm just deciding whether or not to make it a Wait package or an Eat package. At least Eat looks a little more relaxed, but walking in to your megaton home and finding ever chair occupied by hordes of chomping companions would look a bit odd.
Although most people probably don't practise the "Got full condition enclave PA and a plasma rifle? You're retired now" system I do, so their houses wouldn't look too much like a mess hall.
User avatar
Stephanie Kemp
 
Posts: 3329
Joined: Sun Jun 25, 2006 12:39 am

Post » Sat Feb 19, 2011 8:33 am

Nexus issue after all - just got it working I think: http://www.thenexusforums.com/index.php?/topic/180839-site-down-time-today-resolved/page__view__findpost__p__1984224

Just downloaded them now and can open them.
User avatar
meg knight
 
Posts: 3463
Joined: Wed Nov 29, 2006 4:20 am

Post » Sat Feb 19, 2011 10:55 am

Not sure if it's Robco Certified related or not, but if I use "Stand Down" in the combat menu, the game hangs. I only have a single Mr. Gutsy, with the plasma gun upgrade. And Dogmeat, if that matters.
User avatar
мistrєss
 
Posts: 3168
Joined: Thu Dec 14, 2006 3:13 am

Post » Fri Feb 18, 2011 7:25 pm

Talkie-

I've had in my load order these extra esm/esp made by tarrant that allow companions to go to other world spaces (DLC like the Pitt, Point Lookout, etc) with their gear and everything AND not fire them, but then started to wonder if they are needed as this might already handle that.

So does it? Thanks
User avatar
Lindsay Dunn
 
Posts: 3247
Joined: Sun Sep 10, 2006 9:34 am

Post » Sat Feb 19, 2011 1:06 am

Not sure if it's Robco Certified related or not, but if I use "Stand Down" in the combat menu, the game hangs. I only have a single Mr. Gutsy, with the plasma gun upgrade. And Dogmeat, if that matters.
That's odd, I'll see if I can find what's going wrong. Sounds like a loop has gotten stuck.

I've had in my load order these extra esm/esp made by tarrant that allow companions to go to other world spaces (DLC like the Pitt, Point Lookout, etc) with their gear and everything AND not fire them, but then started to wonder if they are needed as this might already handle that.
They're not necessary for CSR/RobCo- you only need those extra files for the default companions.
User avatar
Killer McCracken
 
Posts: 3456
Joined: Wed Feb 14, 2007 9:57 pm

Post » Sat Feb 19, 2011 8:42 am

Talkie,

I bit ago you mentioned 'maybe' you'd look at adapting the vanilla followers use the CSR system as an optional add-on to the compaion core system. Are you still considering this?

I just want to add a plug that I really like how this system works. It's simple and effective . . . and it would be cool if the features could be extended to the vanilla followers as well, but I understand it can get complicated.
User avatar
BlackaneseB
 
Posts: 3431
Joined: Sat Sep 23, 2006 1:21 am

Post » Sat Feb 19, 2011 7:18 am

Talkie,

I bit ago you mentioned 'maybe' you'd look at adapting the vanilla followers use the CSR system as an optional add-on to the compaion core system. Are you still considering this?

I just want to add a plug that I really like how this system works. It's simple and effective . . . and it would be cool if the features could be extended to the vanilla followers as well, but I understand it can get complicated.


Sounds like maybe you saw me asking about this on the nexus page for this mod. :D

I think the mod is simple and great when you're only dealing with companions recruited through CSR, it becomes a bit of a hassle when they're mixed in with regular vanilla followers.

I've been playing with making the mod work with the vanilla followers and had some interesting results; some of these findings might be interesting for general readers, some are mostly directed at TTT:

  • If I console-add aaaCompanionTokenParty to a vanilla follower and then addFormtoFormList that follower to aaaPartyList, I can start to manipulate the follower, however the game hangs if I attempt any command that requires the use of your persistent activators (conceivably because I haven't earned the Companionable perk, or more precisely, started the aaaCompanionQuest). This means that most context-sensitive commands (pantsing, shooting, etc) work, but not wait, follow.
  • After giving myself Companionable, everything appears to work - with some bugs, explained in some more detail below.
  • At this point, this suggests that the mod could work with vanilla followers with some work; could the quest/perk be rearranged such that aaaCompanionQuest starts game enabled, but that the recruiting dialog doesn't appear unless you have the perk?
  • Furthermore, couldn't the relative Hire/Fire topics be altered to simply add or remove the character from aaaPartyList as well as adding/removing aaaCompanionTokenParty, etc as needed in the result script? I'm a FWE user and using Geck/Fo3edit I didn't see any script modifications implemented by FWE that would conflict (as a matter of fact Mez, if you're still reading this - the hire/fire scripts are the same as vanilla except for some commented-out lines from Janos's original mod). I don't use Phalanx or SCC so I wouldn't know about complications with those.


After adding the vanilla followers to CSR and a lot of perusing of the mod data itself, I've found a number of interesting bugs and questions. Some I'm sure are related to the fact that I was forcing CSR to work with vanilla followers, and you may or may not care about making that possible, but others are more general bugs/defects/RFEs:
  • When using the context-sensitive menu option "Attack" or whatever its called (at work, can't verify) - the character will attempt to shoot the target, however there are some issues with this. First, the character shoots through walls (I had Charon shooting Vera Weatherly in her hotel from down the hall. Could this be fixed with a GetLOS check before the UseWeapon command? Second, the UseWeapon call appears to be flagged to automatically hit. Coupled with shooting through walls this is amusing to say the least, but more technically I am concerned about the auto-hit being a balance issue. Lastly, this command didn't appear to 'stick' with vanilla followers, Charon would draw and fire once, but then wig out alternately drawing and sheathing his weapon, finally stopping. When I told him to Wait, he finally resumed killing Vera Weatherly. Again, was using FWE, script/package conflict?
  • Does pantsing need explosives? I seem to be able to do it with Charon regardless of his inventory. Also, after pantsing a mobile target (like the Rivet City hallway guards), when the timer expires the explosion seems to occur at the location where Charon made the plant, not at where the guard is standing.
  • Upon adding aaaCompanionTokenParty to Dogmeat, I noticed he was carrying the Explosives skill token. If'n you were considering adding support for vanilla followers, would this be a simple GetIsCreature check before adding the various skill tokens in the OnAdd block of aaaCompanionTokenParty?

Some general observations:
  • I like the general implementation of the attack command, the UseWeapon seems like it would be useful for forcing a good rifleman to snipe a target from well outside their normal shooting range... which is why I was sorta concerned about the autohit.
  • When I had Charon start fighting people, they fought back against him only. This seems like something of an exploit; like the AI should somehow realize that I'm commanding Charon and in effect, I'm the greater threat.

I love this mod a ton, I'm practically on pause with my current game while I try and figure out how to make this mod work with the general followers. :D
User avatar
Imy Davies
 
Posts: 3479
Joined: Fri Jul 14, 2006 6:42 pm

Post » Sat Feb 19, 2011 10:56 am

Sounds like maybe you saw me asking about this on the nexus page for this mod. :D

I think the mod is simple and great when you're only dealing with companions recruited through CSR, it becomes a bit of a hassle when they're mixed in with regular vanilla followers.

I've been playing with making the mod work with the vanilla followers and had some interesting results; some of these findings might be interesting for general readers, some are mostly directed at TTT:


Thansk for your comments, good to know others are thinking the same thing.

Ideally what I'd like to do is make a CSR-FWE Compatiblity patch that combines some elements of FWE's Followers Enhanced with the global communication/control system of CSR. A little list of ideas come to mind, also to help in the balancing of CSR in the FWE environment.


  • Assuming vanilla followers get supported by CSR, there is still the question of hiring them. Maybe the vanilla companions remain unqiue in thta you don't need to pass the speech checks to persuade them to follow you . . . you just need to have the right Karma, do the right thing, pay them the caps (Jericho, etc..).
  • The follower limits should take into account Vanilla followers and CSR followers. Right now, I can hire about 5 vanilla followers (I ave high Charisma) in addition to half a dozen CSR companions . . . it's little wild running around with 12 people, but maybe that okay too?
  • The healing system in CSR is a bit of a "freebie" from the standpoint of FWE, and I'd love to merge FWE's healing system in. Ideally, all companions should be set to essentially when hired, and then the healing controlled by the FWE scripts, where all companions would heal during or after battle provided they had stimpaks. Limb/body part healing would additionally requrie medical braces or surigical supplies. This system also enables companion's to use the vanilla drugs in special circumstances.
  • Unified command menu, ideally using a custom hotkey (since FWE requires FOSE anyway) instead of the command headset/radio.
  • Lastly, the whole point of this is that the vanilla followers have the same (or similar) menu options, settings, as the CSR followers.

User avatar
Abi Emily
 
Posts: 3435
Joined: Wed Aug 09, 2006 7:59 am

Post » Sat Feb 19, 2011 8:40 am

I bit ago you mentioned 'maybe' you'd look at adapting the vanilla followers use the CSR system as an optional add-on to the compaion core system. Are you still considering this?
Ah, sorry, I've been a little busy as of late (windup to term), and my modding time has been spent fixing infuriating bugs in RobCo (some new bots will only shoot at people outside and try and hug them indoors, which is utterly infuriating).

[*]If I console-add aaaCompanionTokenParty to a vanilla follower and then addFormtoFormList that follower to aaaPartyList, I can start to manipulate the follower, however the game hangs if I attempt any command that requires the use of your persistent activators (conceivably because I haven't earned the Companionable perk, or more precisely, started the aaaCompanionQuest). This means that most context-sensitive commands (pantsing, shooting, etc) work, but not wait, follow.
[*]After giving myself Companionable, everything appears to work - with some bugs, explained in some more detail below.
[*]At this point, this suggests that the mod could work with vanilla followers with some work; could the quest/perk be rearranged such that aaaCompanionQuest starts game enabled, but that the recruiting dialog doesn't appear unless you have the perk?
[*]Furthermore, couldn't the relative Hire/Fire topics be altered to simply add or remove the character from aaaPartyList as well as adding/removing aaaCompanionTokenParty, etc as needed in the result script? I'm a FWE user and using Geck/Fo3edit I didn't see any script modifications implemented by FWE that would conflict (as a matter of fact Mez, if you're still reading this - the hire/fire scripts are the same as vanilla except for some commented-out lines from Janos's original mod). I don't use Phalanx or SCC so I wouldn't know about complications with those.
[/list]

I'm pretty sure you just need to add the party token to add someone to your party, as it then adds the follow token which'll add them to the party list. Assuming you've got the follow commands set up...
The wait/follow commands won't work until you get the perk because of the way commands are handled; CSR doesn't register its follow/wait functions with Core until the perk's taken, to keep the length of the function lists down (so if you had RobCo, WW & CSR active but only took the CSR perk the lists would only be 1 long). That's not really necessary, so sure I can have them start game enabled and make the dialogue contingent on you having the perk.
The vanilla companion recruit dialogues could just be made contingent on "GetItemCount party token == 0" and then add the party token instead of setting them as a follower normally. Otherwise they'd get two sets of settings/follow/wait etc. topics.

After adding the vanilla followers to CSR and a lot of perusing of the mod data itself, I've found a number of interesting bugs and questions. Some I'm sure are related to the fact that I was forcing CSR to work with vanilla followers, and you may or may not care about making that possible, but others are more general bugs/defects/RFEs:
  • When using the context-sensitive menu option "Attack" or whatever its called (at work, can't verify) - the character will attempt to shoot the target, however there are some issues with this. First, the character shoots through walls (I had Charon shooting Vera Weatherly in her hotel from down the hall. Could this be fixed with a GetLOS check before the UseWeapon command? Second, the UseWeapon call appears to be flagged to automatically hit. Coupled with shooting through walls this is amusing to say the least, but more technically I am concerned about the auto-hit being a balance issue. Lastly, this command didn't appear to 'stick' with vanilla followers, Charon would draw and fire once, but then wig out alternately drawing and sheathing his weapon, finally stopping. When I told him to Wait, he finally resumed killing Vera Weatherly. Again, was using FWE, script/package conflict?
  • Does pantsing need explosives? I seem to be able to do it with Charon regardless of his inventory. Also, after pantsing a mobile target (like the Rivet City hallway guards), when the timer expires the explosion seems to occur at the location where Charon made the plant, not at where the guard is standing.
  • Upon adding aaaCompanionTokenParty to Dogmeat, I noticed he was carrying the Explosives skill token. If'n you were considering adding support for vanilla followers, would this be a simple GetIsCreature check before adding the various skill tokens in the OnAdd block of aaaCompanionTokenParty?

UseWeapon is currently really, really absolutely 100% certain to hit as I've been bugged about it not working properly before, as it meant noncombat characters couldn't reliably proc groups of enemies (particularly at low level with robot companions). I'm not hugely keen on it working that way myself, but... It's going to be more-or-less obsoleted when I release the Tactical Combat Order System, which has a much more reliable way of doing it thanks to the extra systems I add in it.
GetLOS doesn't actually check the actor's LOS properly, it checks if there's an uninterrupted line between their roots- at their feet. This means low walls and tables block it, so it's not a hugely useful command unfortunately.
The pants explosion not following once activated is something I hadn't noticed, thanks for pointing it out.
Pants don't require explosives as when it was written we had no way of checking someone's inventory for explosives. We can do that now, so I can try and implement it.
Yeah, all creature combat skills are the same, so his 80 melee skill will also flag him as having 80 explosives and thus being a viable demolitions expert, so a GetIsCreature check would fix that.

Some general observations:
  • I like the general implementation of the attack command, the UseWeapon seems like it would be useful for forcing a good rifleman to snipe a target from well outside their normal shooting range... which is why I was sorta concerned about the autohit.
  • When I had Charon start fighting people, they fought back against him only. This seems like something of an exploit; like the AI should somehow realize that I'm commanding Charon and in effect, I'm the greater threat.
I love this mod a ton, I'm practically on pause with my current game while I try and figure out how to make this mod work with the general followers. :D
I get your concerns over the attack command (I'm annoyed myself as it means melee followers swing and instahit from ranged distances, which is weird) but it's currently the only way for it to fulfil the role it's supposed to do. I think people will generally only use it as intended to initiate combats, rather than exploiting it, not that that's much of an excuse.
Companions ordered to attack enemies being the ones who draw aggro rather than you is again a design thing; some people just don't want to fire guns in this FPS, so if you don't initiate combat yourself enemies tend to avoid you allowing squishy noncombat characters a chance to survive.


I think going ahead with what I'd talked to Mezmorelda about is probably the best solution; it's easy to set something up to use the same components of Companion Core (the orders, the same follow menus etc.) as CSR but with their own specific follow/wait/combat end functions, so the FWE followers can have their own healing (which is handled by the end of combat functions), have the drug using items added by the Follow function, and so on. Alternatively the FWE companions could just be set up to to use CSR's recruitment and the CSR healing/follow functions could be altered to change the healing as it's an ESM so it can easily be altered.
I'll happily try and do either as soon as I've finally finished and relzed new RobCo, it's taking for-sodding-ever.
User avatar
.X chantelle .x Smith
 
Posts: 3399
Joined: Thu Jun 15, 2006 6:25 pm

Post » Fri Feb 18, 2011 9:55 pm

*EDIT* Nevermind. I see that an optional module for vanilla companions is already considered.
User avatar
Nick Pryce
 
Posts: 3386
Joined: Sat Jul 14, 2007 8:36 pm

Post » Sat Feb 19, 2011 1:04 am

Whether or not it gets done is up in the air. I've got a week or so to finish everything for FO3 off, so I don't know if I'll have time- term kicked off last week.
User avatar
Andrew Lang
 
Posts: 3489
Joined: Thu Oct 11, 2007 8:50 pm

Post » Fri Feb 18, 2011 10:51 pm

I'm a bit confused - I'm running WW, CS&R and RCC, which has the newest core atm?

I think its RobCo Certfied but I'm trying to make sure ..
User avatar
James Hate
 
Posts: 3531
Joined: Sun Jun 24, 2007 5:55 am

Post » Fri Feb 18, 2011 8:59 pm

The one updated latest, and with the highest version number in the core readme. Currently RobCo and CSR are on the latest version.
User avatar
phil walsh
 
Posts: 3317
Joined: Wed May 16, 2007 8:46 pm

Post » Sat Feb 19, 2011 9:32 am

Thanks :)
User avatar
adame
 
Posts: 3454
Joined: Wed Aug 29, 2007 2:57 am

Previous

Return to Fallout 3