Okay, I'm working on a mod that will add gold (and eventually other items) to NPCs. What I've done so far is create a token (a Silver Amulet marked as "Unplayable" so the player can't remove it) that gets added to NPC inventories along with the gold to stop the gold from being added in every frame. The script I have so far is:

scn SVGoldAddScriptref ActorBegin GameModeset Actor to GetFirstRef 69 1While Actor  If Actor.getitemcount DontGiveMoneyToken == 0	 Actor.additem Gold001 50	 Actor.additem DontGiveMoneyToken 1  endif  set Actor to GetNextRefloopEnd

However, this causes an immediate CTD every time I load the game. What do I need to do to make this work?

Edit- This is a quest script.

Having these conditions helps narrow down your intended target.

While Actor
if (Actor.GetIsCreature == 0)
if (Actor.GetDead == 0)
if (Actor.GetDisabled ==0)

What is happening here, most likely, is that the script is being executed repeatedly, again and again. This hogs processor power (I think) and can cause the CTD. (Could be wrong though)

Unless the fQuestDelayTime of the quest is adjust externally or in the .ini file this script only runs once every 5 seconds.

I thought that was just for Quest scripts? This one appears to be on an object (Object script)

Not according to http://www.gamesas.com/bgsforums/index.php?showtopic=1073222&st=60&p=15684593&#entry15684593.

You might want to add a ( isFormValid rActor ) catch inside the loop - Ref. walking in external cells sometimes returns null references.

If it is a quest script how will it ever do anything? The quest is not in any cell so how does it know where to look?

getFirstRef walks through the references of the player's parent cell.

Oh, ok thanks.

Thanks for all the replies! This is indeed a quest script (should have put this in my first post :facepalm:)


Something like this?

scn SVGoldAddScriptref ActorBegin GameModeset Actor to GetFirstRef 69 1While Actor If isFormValid rActor == 1  If Actor.getitemcount DontGiveMoneyToken == 0	 Actor.additem Gold001 50	 Actor.additem DontGiveMoneyToken 1  endif  set Actor to GetNextRefloopEnd

Or do I need to put isFormValid rActor somewhere else?

That's correct. Make sure you add an endIf command to match.

:banghead: I tried saving the above change (with a matching Endif) but I got a message saying "rActor not found for parameter int" and the script won't compile. :banghead: I changed rActor to Actor and it did save, so I thought the problem solved. :banghead: No joy. :banghead: Still get an instant CTD. :banghead: What do I need to do to make this work?

Try this script:

scn SVGoldAddScriptref rActorBegin GameMode	set rActor to Apple	set rActor to GetFirstRef 69 1	While (rActor != 0)		If (IsFormValid rActor == 1)			If (rActor.getitemcount DontGiveMoneyToken == 0)				rActor.additem Gold001 50				rActor.additem DontGiveMoneyToken 1			endif		endif		set rActor to Apple		set rActor to GetNextRef	loopEnd

Have you tried using a leveled list?

I tried it. Same result: Instant CTD As soon as the crosshairs passed over an NPC. Thanks though.


Yeah. I get the same result with that too. I'm using OBSE 17b, so I don't think that's the problem. Is there some other way to do this?

Is there a script on your DontGiveMoney token? There is absolutely no reason that script I modified should cause a CTD.

Perhaps you should use ConScribe and PrintToConsole in order to debug the script. But I know it should work just fine.

Are there are other scripts in this mod of yours that are doing something?

Why should the crosshairs be involved? Is there another script/quest trying to add/remove something else to actors.

Nope. The only script in the whole mod was the Quest script. I scrapped the mod and started over. Works perfectly now. Thanks! :foodndrink:


Not sure why the crosshairs were causing this. If I looked straight up or down, I could walk around with no problem. If I looked at an NPC, instant CTD. :shrug:


Thank you all for your help!