[WIP/BRAINSTORM] Community Mod Cleaning Project

Post » Wed Mar 30, 2011 6:08 am

I'm liking the UI changes for this. Too bad there's not a way to make it a bit more prominent than the status bar though. I guess it's ok as long as we educate people to look there for info on underlined mods.

Might also be good to have Bash able to produce a document similar to the patch results that will show a list of mods it underlined and what each one has that needs attention. Perhaps a sub-function of the mod-checker utility?
User avatar
Catherine Harte
 
Posts: 3379
Joined: Sat Aug 26, 2006 12:58 pm

Post » Wed Mar 30, 2011 1:26 am

I'm liking the UI changes for this. Too bad there's not a way to make it a bit more prominent than the status bar though. I guess it's ok as long as we educate people to look there for info on underlined mods.

Might also be good to have Bash able to produce a document similar to the patch results that will show a list of mods it underlined and what each one has that needs attention. Perhaps a sub-function of the mod-checker utility?

Wouldn't be too hard to add it to the mod checker, definitely. Any suggestions on the UI, now's the best time to speak up, I haven't committed anything to the SVN yet. Even then, we can always change things up after, but it'll be best to come to a standard before 292 gets released. I chose underlining, since background color is already taken by things like ghosting and load order issues, and text color is already taken by mergeable and esm's. So that left me with italic/bold/underline/strikethrough.

EDIT: http://img827.imageshack.us/i/wb3.png/ what I've got in the mod checker.
User avatar
dav
 
Posts: 3338
Joined: Mon Jul 30, 2007 3:46 pm

Post » Wed Mar 30, 2011 7:31 am

The mod checker dialogue looks perfect to me. You spelled "Guide" wrong though :P
User avatar
Natasha Biss
 
Posts: 3491
Joined: Mon Jul 10, 2006 8:47 am

Post » Wed Mar 30, 2011 5:05 am

The mod checker dialogue looks perfect to me. You spelled "Guide" wrong though :P


:rofl: speller I am not.
User avatar
Sarah MacLeod
 
Posts: 3422
Joined: Tue Nov 07, 2006 1:39 am

Post » Tue Mar 29, 2011 11:54 pm

That looks great, Lojack. In answer to your earlier question, your regex will work. You might want to just look for "TES4Edit" when checking if it should be cleaned though, as someone mentioned using "Clean with TES4Edit" as a possible opener, and I haven't decided which to use - the one constant is that the "should clean" message will mention TES4Edit, while the "do not clean" message will not, so that's probably the safest thing to look for. :)

EDIT: IIRC the only things that the standard UDR and ITM cleaning doesn't cover is wild edits - if such information could be included in BOSS's messages, then having Bash pick up on that would be good too. Of course, that relies on my thinking up a standard message format for that info. I will have a think, but it's not such a big deal since there's no (AFAIK) place such details on wild edits are stored, so inclusion of that information would be slow going anyway, requiring re-checking of all mods reported with wild edits.

I think what you've got so far is plenty for now, if I do think of anything then it can always be added in later, post 292. The UI isn't going to be affected by any such additions, after all.
User avatar
..xX Vin Xx..
 
Posts: 3531
Joined: Sun Jun 18, 2006 6:33 pm

Post » Wed Mar 30, 2011 6:01 am

I didn't understand the technical details much, but well enough to see that you guys are outdoing yourselves yet once more :D
User avatar
Causon-Chambers
 
Posts: 3503
Joined: Sun Oct 15, 2006 11:47 pm

Post » Tue Mar 29, 2011 7:49 pm

That looks great, Lojack. In answer to your earlier question, your regex will work. You might want to just look for "TES4Edit" when checking if it should be cleaned though, as someone mentioned using "Clean with TES4Edit" as a possible opener, and I haven't decided which to use - the one constant is that the "should clean" message will mention TES4Edit, while the "do not clean" message will not, so that's probably the safest thing to look for. :)

Sounds good. I've got it using the same regex as before, but instead of what I was doing before, Bash will just check to see if the message contains "TES4Edit" to determine if cleaning is required.
User avatar
Antonio Gigliotta
 
Posts: 3439
Joined: Fri Jul 06, 2007 1:39 pm

Post » Wed Mar 30, 2011 12:02 am

EDIT: IIRC the only things that the standard UDR and ITM cleaning doesn't cover is wild edits - if such information could be included in BOSS's messages, then having Bash pick up on that would be good too.

So long as everyone keeps in mind that wild edits cannot be automatically cleaned. They all need to be checked on an individual basis and should really only be changed if you know enough about the mod to be sure it's not intentional.
User avatar
rheanna bruining
 
Posts: 3415
Joined: Fri Dec 22, 2006 11:00 am

Post » Wed Mar 30, 2011 7:44 am

So long as everyone keeps in mind that wild edits cannot be automatically cleaned. They all need to be checked on an individual basis and should really only be changed if you know enough about the mod to be sure it's not intentional.

Indeed - the idea is that those in the know can identify what precisely are the wild edits in a plugin and then let others know these details, rather than simply telling people that there are wild edits, but not which edits those are, which is currently the case.
User avatar
Jordan Fletcher
 
Posts: 3355
Joined: Tue Oct 16, 2007 5:27 am

Post » Tue Mar 29, 2011 11:39 pm

Hi,
Watching this thread with interest. About 3 weeks ago I went and finally Cleaned some of my mods. Started from top of my load order and using the List in the thread went thru and found all the mods on the list I have. a lot of my mods are not on any list and not really knowing what I am doing, I skipped those mods. This looks like it will help people like me that , Don't really know WHY we are clicking this option, and cleaning this out then cleaning that out. We are just doing as told!...lol

My install is solid. seams more responsive now? Not really sure, after cleaning about half the mods I played most of the day on a SAT and that went for 5.5 hours before the crash. Tomorrow I plan on playing all Day. have about 2200 Quests to Get too.....hahhah.

I can Play for hours on end , Load or Go thru hundreds of Doors. Then there is a Crash going thru some door. go right back and no problem.
Most, if not all sessions go for more than an Hour. then there is weird random slow downs. then back to good.
In 2 years with this FCOM install I just had my First Corrupt save? (deleting that save only lost me 20 mins) ...lol

Hope I didn't mess up and clean something I shouldn't have .I will know for sure tomorrow tho.

Thanks to all you that keep doing all the magic! :hugs:

Still have yet to ..pee y Fi all my meshes too!<<My guess to the above...Onra's Heigth map, Unique landscape, Better cities, Tes4lod. and me not knowing who should win and when.
User avatar
Rachel Briere
 
Posts: 3438
Joined: Thu Dec 28, 2006 9:09 am

Post » Tue Mar 29, 2011 10:11 pm

Sounds good. I've got it using the same regex as before, but instead of what I was doing before, Bash will just check to see if the message contains "TES4Edit" to determine if cleaning is required.


Would it be possible to have a function in WB, or perhaps just something similar to a bash tag so that you know you've cleaned the mod. Because I'm the sort of person to forget and will no doubt keep on trying to clean my clean mods :(.

Even if the user has to enter it into the description themselves, or just an option when you right click to tell bash you've cleaned the mod??
User avatar
victoria gillis
 
Posts: 3329
Joined: Wed Jan 10, 2007 7:50 pm

Post » Wed Mar 30, 2011 12:43 am

Would it be possible to have a function in WB, or perhaps just something similar to a bash tag so that you know you've cleaned the mod. Because I'm the sort of person to forget and will no doubt keep on trying to clean my clean mods :(.

Even if the user has to enter it into the description themselves, or just an option when you right click to tell bash you've cleaned the mod??

See:

Anywho, here's what the http://img858.imageshack.us/i/wb1.png/ looks like, with an http://img848.imageshack.us/i/wb2a.png/ I still need to add a per-mod option to mark it as already cleaned, so even if BOSS says it's dirty, you can mark it as being cleaned.


So he's planning to do so, at least. :shrug: In any case, you should never have a case in which you're getting a false positive (when the system is in place, that is), because it uses CRC comparisons looking for dirty mods. If your mod is clean, its CRC won't match the given dirty CRC, and you won't get a message from BOSS, and therefore also no message from Bash. It's still good to have a manual override though. :)
User avatar
Betsy Humpledink
 
Posts: 3443
Joined: Wed Jun 28, 2006 11:56 am

Post » Tue Mar 29, 2011 8:18 pm

So he's planning to do so, at least. :shrug: In any case, you should never have a case in which you're getting a false positive (when the system is in place, that is), because it uses CRC comparisons looking for dirty mods. If your mod is clean, its CRC won't match the given dirty CRC, and you won't get a message from BOSS, and therefore also no message from Bash. It's still good to have a manual override though. :)
Exactly correct. In fact, Wrye Bash currently isn't checking the mod name at all, just the CRC vs. BOSS's masterlist.

http://img641.imageshack.us/i/wb3d.png/ the new option to disable dirty scanning on a per-mod basis. Beware though, if the crc of the mod changes, this will get reset back to being checked against the masterlist again.

EDIT: Looks like everything on Wrye Bash's end is good to go now (with the exception of possibly automating the cleaning process in the future, at least for ITM and UDR). I suppose we still need a way to make BAIN not complain about the cleaned versions.
User avatar
Matthew Warren
 
Posts: 3463
Joined: Fri Oct 19, 2007 11:37 pm

Previous

Return to IV - Oblivion