Hi, ive been working on a small mod, that adds in Zanpaktou-like swords, from the anime bleach, at the moment im stuck with a single bit of script im trying to make a spell that gives you a different weapon depending on which of the 5 following skills are highest blade, blunt, marksman, destruction and alchemy

below is one of the attempts at getting this to work, any insights would be incredibly usefull, thanks in advance

Ogliss

if ( getav blade > getav blunt && getav marksman && getav destruction && getav alchemy )
player.additem ZPTBladeShikai 1
player.Equipitem ZPTBladeShikai
elseif ( getav blunt > getav blade && getav marksman && getav destruction && getav alchemy )
player.additem ZPTBluntShikai 1
player.Equipitem ZPTBluntShikai
elseif ( getav marksman > getav blade && getav blunt && getav destruction && getav alchemy )
player.additem ZPTMarksmanShikai 1
player.Equipitem ZPTMarksmanShikai
elseif ( getav destruction > getav blade && getav marksman && getav blunt && getav alchemy )
player.additem ZPTDestructionShikai 1
player.Equipitem ZPTDestructionShikai
elseif ( getav alchemy > getav blade && getav marksman && getav destruction && getav blunt )
player.additem ZPTAlchemyShikai 1
play

You have to check every condition against something.
And making a variable for each attribute makes the coding easier and more effecient.
You also need to specify the reference as the player, unless you are running the script 'on' the player.
And what happens when your highest two attributes are the same value?
And lastly, you cannot equip an item in the same execution frame that you add it to the player. It will not work.

set mybla to player.getAv bladeset myblu to player.getAv bluntset mymar to player.getAv marksmanset mydes to player.getAv destructionset myalc to player.getAv alchemyif mybla >= myblu && mybla >= mymar && mybla >= mydes && mybla >= myalc	player.additem ZPTBladeShikai 1	player.Equipitem ZPTBladeShikaielseif myblu >= mybla && myblu >= mymar && myblu >= mydes && myblu >= myalc	player.additem ZPTBluntShikai 1	player.Equipitem ZPTBluntShikaielseif ...

Given the above post, you want something like this:

scn examplescriptref weaponshort valueBegin OnActivate	set weapon to ZPTBladeShikai	set value to Player.GetAV Blade	if (value < Player.GetAV Blunt)		set weapon to ZPTBluntShikai		set value to Player.GetAV Blunt	endif	if (value < Player.GetAV Marksman)		set weapon to ZPTMarksmanShikai		set value to Player.GetAV Marksman	endif	if (value < Player.GetAV Destruction)		set weapon to ZPTDestructionShikai		set value to Player.GetAV Destruction	endif	if (value < Player.GetAV Alchemy)		set weapon to ZPTAlchemyShikai	endif		Player.AddItem weapon 1	EndBegin GameMode	if (weapon)		if (Player.GetEquipped weapon)			set weapon to 0		else			Player.EquipItem weapon		endif	endif	End

OnActivate and GameMode blocks do not run in a spell script.

You need to use ScriptEffectStart.
Finish the script I have above and it should work fine.

The next three elseif conditions will check if mymar, then mydes, then myalc are greater than the other abilities.