Problem with "new clothes" quest : III

» Sun Aug 15, 2010 1:36 pm

Hey everyone,

I originally posted this in the Uvirith's legacy thread because I thought it was caused by that mod, but it turns out it wasn't so to avoid spamming up Stuporstar's thread, I'm making a new one here.

edit: maybe I should say the problem too

Basically, when I equip therana's skirt, she doesn't attack me.

This is my mod list:

Spoiler

~~GameFile0=Morrowind.esm~~
~~GameFile1=Tribunal.esm~~
~~GameFile2=Bloodmoon.esm~~
~~GameFile3=Better Heads.esm~~
~~GameFile4=Better Heads Tribunal addon.esm~~
~~GameFile5=Better Heads Bloodmoon addon.esm~~
~~GameFile6=Rise of House Telvanni.esm~~
GameFile7=Assassins Armory.esm
GameFile8=MCA.esm
GameFile9=Morrowind Patch v163.esm
GameFile10=Morrowind Advanced.esm
GameFile11=MW_Adv_Required.esp
~~GameFile12=MCA - Guards Patch.esp~~
GameFile13=Westly's Master Headpack X.esp
~~GameFile14=Better Bodies.esp~~
GameFile15=New Argonian Bodies - Clean.esp
GameFile16=New Khajiit Bodies - Clean.esp
GameFile17=Psy_VivecGodReplacer_Tribunal.esp
GameFile18=ProjectileStoreAndSpeed.esp
GameFile19=New Classes V7.esp
GameFile20=ExpandedBirthsigns4Purists.esp
~~GameFile21=Assassins Armory - No Scripts.esp~~
~~GameFile22=Assassins Armory - Unofficial Patch 77.esp~~
~~GameFile23=farrp_WeaponCompilationMod_V2.esp~~
~~GameFile24=DB_Attack_Mod.esp~~
~~GameFile25=Illuminated Order v10.esp~~
GameFile26=Illuminated Order v10 - Bloodmoon Compatibility Extras.esp
GameFile27=Balance - Character.esp
GameFile28=BTB - Alchemy.esp
GameFile29=BTB - Settings.esp
GameFile30=BTB - Spells.esp
GameFile31=EcoAdjCrime.esp
GameFile32=EcoAdjMerchantSkills.esp
GameFile33=Madd Leveler - Base.esp
GameFile34=Madd Leveler - Madd Caps.esp
GameFile35=Madd Leveler - Quest Cap Remover.esp
GameFile36=Madd Leveler - Vampire Cap Remover.esp
GameFile37=Madd Leveler - Werewolf Cap Remover.esp
GameFile38=Madd Leveler - Assassin's Armory Fix.esp
GameFile39=Madd Leveler - Illuminated Order Fix.esp
GameFile40=Spect Sorcery pt 1.esp
~~GameFile41=master_index.esp~~
~~GameFile42=TheForgottenShields - Artifacts_VN.esp~~
~~GameFile43=Uvirith's Legacy_Final_PreRelease.esp~~
GameFile44=UL_RoHT_1.4_Compatibility.esp
GameFile45=Madd Leveler - Madd Health.esp
GameFile46=Mashed Lists.esp

» Sun Aug 15, 2010 1:36 pm

This is the very helpful reply from Artimis Fowl:

I doubt you're really to terribly interested in finding out the culprit mod, and would rather get along with your game, so i suggest the following(hopefully i have these commands right):

first, open your game and the console and type:

Spoiler

getjournalindex"HT_TheranaClothes"

this should return 50, if it does not then we have found our problem, and you need to put this into the console

Spoiler

setjournalindex"HT_TheranaClothes"50

and try therana again after reequipping the skirt.
second, if the above doesn't solve your problem, you can also force the needed dialog to happen. go to Therana, open the console, and click on her. then type the following:

Spoiler

set"wearingClothes"1

The result should be one very angry Therana and the intended dialog. If she doesn't force greeting, we know its a script error, and if she says the wrong thing after forcing the greeting, we know its a dialog problem.
In the case that that doesn't get the desired result, we can also arrange to skip this portion of the quest by opening the console and typing

Spoiler

Journal HT_TheranaClothes 70

and then continuing according to your journal instructions, namely going back to Therana's mouth and moving on with your adventure.

If i am mistaken and you do wish to identify the problem mod, the second step is still a relevant method of elimination. this will tell you what to look for when you go through your mods, opening each with their dependents as an "active mod" in the CS. While it is possible that other utilities could get to this information faster, it may not be really worth your time getting used to the different interfaces. I personally like http://planetelderscrolls.gamespy.com/View.php?view=Other.Detail&id=52 for this purpose, but that's just me.

» Sun Aug 15, 2010 10:01 am

and here is my reply:

snip

thanks for the advice, I tried it. My results:

When she first asks me to put on the skirt, my journal doesn't get updated (first console command returns 10 rather than 50)

When I console the journal to 50 and equip the skirt, nothing happens.

When I use the console command set "wearingclothes" to 1, she forces dialogue, gives me the proper speech about wearing her clothes, and attacks as usual.

So all in all it worked, but I'm even more confused as to what is going wrong... is it the skirt's script or therana's?

» Sun Aug 15, 2010 9:06 pm

and here is my reply:

thanks for the advice, I tried it. My results:

When she first asks me to put on the skirt, my journal doesn't get updated (first console command returns 10 rather than 50)

When I console the journal to 50 and equip the skirt, nothing happens.

When I use the console command set "wearingclothes" to 1, she forces dialogue, gives me the proper speech about wearing her clothes, and attacks as usual.

So all in all it worked, but I'm even more confused as to what is going wrong... is it the skirt's script or therana's?

if the command "wearingclothes" works on therana, then the problem is with the skirt. when you equip the skirt in the same cell as therana it should change that variable, but it isn't for one reason or another. This may be because the journal entry wasn't updated when you first spoke with Therana. So there may be an error in either the skirt script, ~~or a dialog error that messed up the quest start~~, preventing therana from telling you to put the skirt on, or both by some odd coincidence. The fact that she didn't attack after you set the journal correctly though suggests the error is with the skirt, not her.

~~The other confusing thing is that your journal didn't update correctly, i'm not sure what caused this. I'll have to check what dialog entry you missed/messed up.~~
correction: it seems that journal entry doesn't effect the quest progress, nothing is defined for only above 10, its 10 and up, so that had nothing to do with the problem. That narrows it down to only the skirt to blame.

» Sun Aug 15, 2010 11:27 pm

I'm in the process of opening each mod in the CS to check if there's an asterisk beside therana's skirt, but I've just realized that I can't actually check if the .esms change anything because I can't load them as master files... so it doesn't show me any asterisks :bonk:

I'm gonna edit the first post to cross out the mods that don't show any changes to therana's skirt.

» Sun Aug 15, 2010 6:35 pm

I'm in the process of opening each mod in the CS to check if there's an asterisk beside therana's skirt, but I've just realized that I can't actually check if the .esms change anything because I can't load them as master files... so it doesn't show me any asterisks :bonk:

I'm gonna edit the first post to cross out the mods that don't show any changes to therana's skirt.

sadly, you may also have to check for any that modifies the script on the skirt. They could potentially do that without touching the actual item.

» Sun Aug 15, 2010 4:25 pm

I may have found the culprit with tesame:

EcoAdjCrime.esp

apparently it does something to rebalance morag tong writs, and since therana is marked for a morag tong assassination, they changed her script.

This is Therana's original script:

Spoiler

Begin BILL_MT_WritTherana
; log a journal entry for each successful 'hit' the player performs for the Morag Tong

; script location: should be placed on each and every target of the Morag Tong, with
; changes to reflect the person it is running on.

short CL1
short CL2

;for HT_NewClothes
short wearingClothes
short doOnce
short noLore

if ( MenuMode == 1 )
return
endif

if ( doOnce == 0 )
if ( wearingClothes == 1 )
ForceGreeting
Set doOnce to 1
endif
endif

if ( CellChanged == 1 )
;keep her from going off over and over.
StopCombat
SetFight 30
set CL1 to GetPCCrimeLevel
endif

if ( OnDeath == 1 )
; when we are killed...

Set TelvanniDead to ( TelvanniDead + 1 )
;for Telvanni Hortator...

if ( GetJournalIndex MT_WritTherana > 0 )
; ... and if the player has a writ for us...

set CL2 to GetPCCrimeLevel
if ( CL2 > CL1 )
; ... append a journal entry if the execution is seen ...
Player->Journal MT_WritTherana 80
else
; ... append a journal entry if the execution is NOT seen ...
Player->Journal MT_WritTherana 90
endif
endif
endif

End

This is the new script:

Spoiler

Begin BILL_MT_WritTherana
; log a journal entry for each successful 'hit' the player performs for the Morag Tong

; script location: should be placed on each and every target of the Morag Tong, with
; changes to reflect the person it is running on.

long CL1
long CL2

;for HT_NewClothes
short wearingClothes
short doOnce
short noLore

if ( MenuMode == 1 )
return
endif

if ( doOnce == 0 )
if ( wearingClothes == 1 )
ForceGreeting
Set doOnce to 1
endif
endif

if ( CellChanged == 1 )
;keep her from going off over and over.
StopCombat
SetFight 30
set CL1 to GetPCCrimeLevel
endif

if ( OnDeath == 1 )
; when we are killed...

Set TelvanniDead to ( TelvanniDead + 1 )
;for Telvanni Hortator...

if ( GetJournalIndex MT_WritTherana > 0 )
; ... and if the player has a writ for us...

set CL2 to GetPCCrimeLevel
if ( CL2 > CL1 )
; ... append a journal entry if the execution is seen ...
Player->Journal MT_WritTherana 80
else
; ... append a journal entry if the execution is NOT seen ...
Player->Journal MT_WritTherana 90
endif
endif
endif

End

I don't know anything about scripting, so does anyone see what the problem could be? I'm gonna look at it once I've posted it.

edit: ok the only difference I can see is that in the first one it says short CL1 short CL2 and in the second one it says long CL1 long CL2

I have no idea what that means however.

edit again: alright I don't understand scripting, but it seems to me like this should be ok no? I mean it still checks for the wearingclothes variable... but I can't find any mods that alter the actual skirt's script :huh:

» Sun Aug 15, 2010 6:30 pm

I may have found the culprit with tesame:

EcoAdjCrime.esp

apparently it does something to rebalance morag tong writs, and since therana is marked for a morag tong assassination, they changed her script.

This is Therana's original script:
-snip-
I don't know anything about scripting, so does anyone see what the problem could be? I'm gonna look at it once I've posted it.

edit: ok the only difference I can see is that in the first one it says short CL1 short CL2 and in the second one it says long CL1 long CL2

I have no idea what that means however.

edit again: alright I don't understand scripting, but it seems to me like this should be ok no? I mean it still checks for the wearingclothes variable... but I can't find any mods that alter the actual skirt's script :huh:

you're 100% right, the above script changes don't effect the quest as far as i can tell. As your ingame tests show, whenever the wearingclothes variable changes therana attacks as she should, but for one reason or another, equipping the skirt isn't changing that variable as it should. Thus, the script you're checking for changes in would be the one on the skirt, not therana. I believe it's called theranaSkirtScript (creative isn't it?). It is also possible that a bad reference could have just corrupted the skirt object. Just for curiosities sake, perhaps you should go ingame, drop the skirt, open the console and type TFH, then close the console and look at the skirt. It wont tell us what's wrong or who the culprit is, but at least we can see if someone renamed/removed the script.

edit: it's entirely possible this could just be a bad reference problem only associated with 1 save, perhaps doing a speed run with a new character to see if the bug persists?

» Sun Aug 15, 2010 6:04 pm

when I write tfh, it tells me that the skirt's script is called theranaskirtscript, so the name at least hasn't been changed/removed. I just did two speedruns with different characters and they both had the same problem

I'll look at all my mods with tesame again later today, I must have missed something because I don't remember seeing anything that altered the skirt's script.

» Sun Aug 15, 2010 4:41 pm

I'd suggest doing a speedrun with half of the mods active - if you run into the issue, you know that one of the mods is the culprit, if not, then a mod from the other half is to blame. Then you can check with half of those mods active (or with the other half if the issue isn't there) and so on until you find the offending mod.