Quick and easy feedback : IV

» Fri May 13, 2011 10:42 pm

I normally don't mod, but I'm finally getting around to learning just enough of the TES Script language to modify the Bank of Cyrodiil mod. Basically I wanted to set it up so that there are tiers of interest instead of the base .005, and just wanted to toss out my scrip to see if you guys think it would fly.

So here is the new script I made for it...

if ( interestdays > 0 )
set PCmercantile to player.GetActorValue mercantile
if ( ZABankGold < 2500 )
set interest to ( interestdays * ZABankGold * ( 0.004 + ( PCmercantile / 50000 ) ) )
elseif ( ZABankGold > 2499)
set interest to ( interestdays * ZABankGold * ( 0.0055 + ( PCmercantile / 50000 ) ) )
elseif ( ZABankGold > 4999 )
set interest to ( interestdays * ZABankGold * ( 0.0065 + ( PCmercantile / 50000 ) ) )
elseif ( ZABankGold > 9999 )
set interest to ( interestdays * ZABankGold * ( 0.0075 + ( PCmercantile / 50000 ) ) )
endif
set ZABankgold to ( ZABankGold + interest )
set ZABankInterestEarned to ( ZAbankinterestEarned + interest)
set interestdays to 0
endif

The only thing I wonder about his will the "greater than" part of the script be smart enough to go to the next line, or will I have to absolutely define the parameters like this?

....
elseif ( ZABankgold == 2500 ) && ( ZABankGold < 5000 )
....

(Forgive the lack of tab-over on the script... apparently it doesn't like that sort of thing on this site)

» Fri May 13, 2011 9:35 pm

Elseif (ZABankgold == 2500) && (ZABankGold < 5000) will only be true for the number 2500.

Further more check this part here:

elseif ( ZABankGold > 2499)set interest to ( interestdays * ZABankGold * ( 0.0055 + ( PCmercantile / 50000 ) ) ) - This will always be true if the gold is 2500 or more. Even if it is 100000 it will still be true. However, since the same variable is modified in the next line you don't have to add additional conditions, but as good coding practice you should always get into the habit of making your code as conditioned as possible.elseif ( ZABankGold > 4999 )set interest to ( interestdays * ZABankGold * ( 0.0065 + ( PCmercantile / 50000 ) ) ) elseif ( ZABankGold > 9999 )set interest to ( interestdays * ZABankGold * ( 0.0075 + ( PCmercantile / 50000 ) ) )

What you need to do is the following:

if ( ZABankGold < 2500 )set interest to ( interestdays * ZABankGold * ( 0.004 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold >= 2500) && (ZABankGold < 5000)set interest to ( interestdays * ZABankGold * ( 0.0055 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold >= 5000) && (ZABankGold < 10000)set interest to ( interestdays * ZABankGold * ( 0.0065 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold > 10000 )set interest to ( interestdays * ZABankGold * ( 0.0075 + ( PCmercantile / 50000 ) ) )

There is such a thing as equal to or grater than ( >= ) and equal to or less than ( <= ).

P.S. Make sure you add a check or a condition that will make this script run once in a day (or an hour, or whatever your parameter is), as this way it will run once every 5 seconds (if it's a quest script) or once every frame (if it's an object script)

» Fri May 13, 2011 9:52 pm

What you need to do is the following:

if ( ZABankGold < 2500 )set interest to ( interestdays * ZABankGold * ( 0.004 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold >= 2500) && (ZABankGold < 5000)set interest to ( interestdays * ZABankGold * ( 0.0055 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold >= 5000) && (ZABankGold < 10000)set interest to ( interestdays * ZABankGold * ( 0.0065 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold > 10000 )set interest to ( interestdays * ZABankGold * ( 0.0075 + ( PCmercantile / 50000 ) ) )

This isn't very good code either, as you make twice as many checks as you have to. This is much clearer:

if ( ZABankGold < 2500 )  set interest to ( interestdays * ZABankGold * ( 0.004 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold < 5000 )  set interest to ( interestdays * ZABankGold * ( 0.0055 + ( PCmercantile / 50000 ) ) )elseif ( ZABankGold < 10000 )  set interest to ( interestdays * ZABankGold * ( 0.0065 + ( PCmercantile / 50000 ) ) )else  set interest to ( interestdays * ZABankGold * ( 0.0075 + ( PCmercantile / 50000 ) ) )endif

If the first if fails (ZABankGold < 2500), there is no need to check that ZABankGold >= 2500 in the following elseif, etc.

» Fri May 13, 2011 8:57 pm

Thanks guys. Just as soon as I accumulate 10k gold I can do a nice controlled test.

» Sat May 14, 2011 12:33 am

Just a final update to let you guys know that it works! Thanks again.