I am unsure if this right place to post this but I think it is.

So basically I am trying to script a reward for a loyalty quest for a NPC I created. I have quest all structured all the voiceacting is working and quest completes itself, however, even though I have my NPC set as:

PotentialFollowerFaction=0

CurrentFollowerFaction=-1

AND the last stage of the quest is set as:

Well how would changing the relationship do anything? Do you have conditions on voice acting after the quest ensuring that is his relationship with you? Is your quest Stop()ped when done, and if so you should have his ending dialogue in a separate quest started before you stop the prior quest. Do you?

Also, if you're going to script that, might as well make it more efficient:

Instead, use:

Alias_Falvius.GetActorReference().SetRelationshipRank(Game.GetPlayer(), 2)

Game.GetPlayer() is inefficient as well but you're just using it once in that fragment so it's fine.

Well changing the relationship should allow him to use the follower dialogue, I thought thats the way followers work:

You have them part of the factions Potential Follower and Current Follower and then the relationship needs to be established but in loyalty quest it is enabled via the quest scripting.

There is no tutorial for this online so I am trying to figure this out on my own.

The conditions was that you complete the quest unless I am misunderstanding what you mean,

I am a beginner so I am a little confused what you mean: The quest is completed when you talk to him and say something, he responds positively and you should get the relationship boost. However, nothing seems to happen.

When you set a custom follower generally it has I need you to follow me in the dialogue already, do I need create a new dialogue for the follow me?

There are plenty of tutorials on this online. Here's 5:

http://deck16.net/post/22645519500/making-a-unique-voiced-follower-in-skyrim-part-1

http://wiki.tesnexus.com/index.php/Adding_a_Follower_NPC_to_Skyrim

https://www.youtube.com/watch?v=AlepT3rQ8LI

http://steamcommunity.com/groups/SkyrimCKPublic/discussions/1/882959061768715596/

http://skyrimmw.weebly.com/skyrim-modding/making-a-custom-follower-framework-skyrim-modding-tutorial

Well I appreciate that!