I'm trying to make it so they when you put on clothing and/or armour associated with a faction you are added to that faction, unless of course you're already in the faction in which case I want it to do nothing. Then I need to reverse the whole thing when you take off the clothing/armour. Here's my script:

scriptName MythicDawnClothingbegin GameMode	if player.getequipped 00024DE2 && player.getequipped 0008D755 && (player.getinfaction MythicDawn == -1) == 1		player.setfactionrank MythicDawn 0	endif	if player.getequipped 00024DE2 && player.getequipped 0008D755 && player.getinfaction MythicDawn == 0		player.setfactionrank MythicDawn -1	endifend

Any help would be greatly appreciated.

- Ryan Paul Fialcowitz

Interesting. Didn't know it is possible to use a hex id in a script. But it's not a good idea, anyway.

What's wrong with your script is the part (player.getinfaction MythicDawn == -1) == 1

getinfaction returns 0, if the player is not a member. Unlike getfactionrank, which you probably had in mind.
And the '== 1' at the is unnecessary.

Possible, but It's not a good idea to use form ids in a script, use the editor ids instead. This is probably another reason it wont work. Why? Because form ids of items change based on load order, so this is why they came up with editor ids

My revised script which works:

scriptName MythicDawnClothingbegin GameMode	if (player.getequipped 00024DE2 && player.getequipped 0008D755 == 1) && player.getinfaction 00029F82 == 0		player.setfactionrank 00029F82 0	endif	if (player.getequipped 00024DE2 && player.getequipped 0008D755 == 0) && player.getinfaction 00029F82 == 1		player.setfactionrank 00029F82 -1	endifend

If anyone is interested all you would need to do is switch out the FormIDs and you could make this work for any equipment/faction combination. Thanks for the help.

- Ryan Paul Fialcowitz

People tell you not to use Form ID's in scripts and you replace the last few editor ID's you had in the script with Form ID's. :unsure:

There's also the minor problem that if you were in the faction before equipping the items, your script doesn't record that and unconditionally expels you from the faction when you unequip. The DB faction, for example, likes to kill its ex-members.

I haven't had much luck with Editor IDs in Fallout 3 where I've had the most experience scripting, while Form IDs always work. Yes, there is the load order issue - but what can I do if it didn't work with Editor IDs? However, it DID work with The Elder Scrolls IV - Oblivion. So, consider me admonished. . .



How do I fix this issue? My scripting knowledge is clearly quite limited. I would appreciate some input on this matter and, of course, thanks for all the replies.

UPDATE
I got it to work. Now the script does nothing if you wear or remove the clothing whilst already a member of the faction.

scriptName MythicDawnClothingshort AlreadyInFactionshort NotInFactionbegin GameMode		if player.getinfaction MythicDawn == 1		set AlreadyInFaction to 1	endifendbegin OnEquip	if (player.getequipped MythicDawnRobe && player.getequipped MythicDawnRobeHood == 0) && AlreadyInFaction == 0		player.setfactionrank MythicDawn 0		set NotInFaction to 1	endifendbegin OnUnequip	if NotInFaction == 1		player.setfactionrank MythicDawn -1		set NotInFaction to 0	endifend

- Ryan Paul Fialcowitz

I have coded FO3 scripts since it came out and have never had a problem with using the Editor ID. Ever... And I write tons of scripts, just look at any of my released mods to see proof of that. So the problem was probably not the Editor ID.