Alright so as a programmer myself I understand how hard it is to read another person's code and help them out so I will do my best to make it easier for everybody here to understand.

Here is the code

Scriptname _SoulsSummoningOverhaul extends ActiveMagicEffectSoulGem Property pettyFilled  Auto  KeyWord Property VendorItemSoulGem AutoSoulGem Property pettyEmpty  Auto  SoulGem Property lesserFilled  Auto  SoulGem Property lesserEmpty  Auto  SoulGem Property commonFilled  Auto  SoulGem Property commonEmpty  Auto  SoulGem Property greaterFilled  Auto  SoulGem Property greaterEmpty  Auto  SoulGem Property grandFilled  Auto  SoulGem Property grandEmpty  Auto  SoulGem Property blackFilled  Auto  SoulGem Property blackEmpty  Auto  Actor Property PlayerRef  Auto  Actor Property familiar  Auto  Message Property soulsMessage1  Auto  Int Property soulPoints  Auto  Event onEffectStart(Actor akTarget, Actor akCaster);Check for Soul Gems, if none in inventory interrupt spell    If(akTarget == PlayerRef)            If(akTarget.GetItemCount(VendorItemSoulGem) <= 0)            akTarget.InterruptCast()            Debug.Notification("I need soul gems in order to summon my creatures . . .")        ElseIf(akTarget.GetItemCount(VendorItemSoulGem) >= 1)            Game.DisablePlayerControls(False, False, False, False, False, True)            Game.EnablePlayerControls(False, False, False, False, False, True)            soulsMenu()        EndIf    EndIfendEventFunction soulsMenu(Bool menuActive = true, int button = 0)    ;Show the menu    While menuActive        If button != -1            button = soulsMessage1.Show()            ElseIf button == 0 ;This is for petty gems                Game.GetPlayer().removeItem(pettyFilled, 1, false)                Game.GetPlayer().addItem(pettyEmpty, 1, false)            ElseIf button == 1 ;This is for lesser gems                Game.GetPlayer().removeItem(lesserFilled, 1, false)                Game.GetPlayer().addItem(lesserEmpty, 1, false)            ElseIf button == 2 ;This is for common gems                Game.GetPlayer().removeItem(commonFilled, 1, false)                Game.GetPlayer().addItem(commonEmpty, 1, false)            ElseIf button == 3 ;This is for greater gems                Game.GetPlayer().removeItem(greaterFilled, 1, false)                Game.GetPlayer().addItem(greaterEmpty, 1, false)            ElseIf button == 4 ;This is for grand gems                Game.GetPlayer().removeItem(grandFilled, 1, false)                Game.GetPlayer().addItem(grandEmpty, 1, false)            ElseIf button == 5 ;This is for black gems                Game.GetPlayer().removeItem(pettyFilled, 1, false)                Game.GetPlayer().addItem(pettyEmpty, 1, false)                               ;This is for quitting            ElseIf button == 6                menuActive = false        EndIf    EndWhileendFunctionMagicEffect Property NewProperty  Auto

Whats the point of the program?

The point of the program is to open the soul summoning menu when a summon spell is cast. What it will do is check the player's inventory for soul gems filled soul gems. If any are available the menu will open up before casting the creature. However, if no soul gems or no filled soul gems are availabe the spell will be interrupted (not cast). I know for a fact that the menu works, I tested it with an activator.

Whats the problem?

For some reason when I cast the summon spell "Conjure Familiar" which I attached the script to its magic effect, the summon will still be cast with or without the soul gems but the notification will still appear when the player has no soul gems. Also when the player does have soul gems the menu does not pop up.

My thoughs on this.

Well honestly I cannot find any flaws with the code, so it might be a logic error. However, I may have wrongly attached the script or it has something to do with the soulsMenu function.

Any help you give will be greatly appreciated and when the mod goes up you will have your username on the credits for your support and advice.

P.S I am new to this forum so if I have posted incorrectly please let me know as well.

In the OnEffectStart Event, the spell has already been cast so InterruptCast does nothing. Also, for your soulsmenu, it looks like you get stuck in a while loop unless the player chooses to quit? I can't see any reason why you need the while menuActive and if button != -1, since those conditions will always be true at the start of your function.

Wow First off, thank you for the quick replies I will start applying both of your fixes straight away!

@Templar - Edit didn't realize you used a variable to hold the player value. Ok that's a lot to fix but by player you mean Game.player rather than game.getPlayer() right?

- I guess I will create my own keyword then and add it to the filled gems

@mojo22 - The while loop is to keep the player from selecting one option and then getting kicked out of the menu. So it is set up like that so that a quit button needs to be selected in order to quit. Though I will take a look at it and see if I can code it better.

Also is there an event that will check the spell before it is cast?

Is there an event that checks before the spell is cast? Because I cannot seem to find it.

Thanks

RegisterForAnimationEvent may be a way to detect something before a spell cast. However... you could try something like this...

Scriptname _test_testscript extends ActiveMagicEffectActor Property PlayerRef  Auto  Message Property soulsMessage1  Auto  FormList Property SoulsEmpty Auto ;0 = petty, 1 = lesser, 2 = common, etcFormList Property SoulsFilled Auto ;0 = petty, etcEvent onEffectStart(Actor akTarget, Actor akCaster);Check for Soul Gems, if none in inventory interrupt spell    If(akTarget == PlayerRef)        If(akTarget.GetItemCount(SoulsEmpty) < 1)            Debug.Notification("I need soul gems in order to summon my creatures . . .")            ;SomeMessage.Show() ???            Dispel() ;will kill your summon automatically        Else ;If(akTarget.GetItemCount(VendorItemSoulGem) >= 1)            Game.DisablePlayerControls(False, False, False, False, False, True)            Game.EnablePlayerControls(False, False, False, False, False, True)            int button = soulsMessage1.Show()            if button == 6 ;is option 6 to cancel the cast?                Dispel()            else                PlayerRef.RemoveItem(SoulsEmpty.GetAt(button))                PlayerRef.AddItem(SoulsFilled.GetAt(button))             endIf        endIf    endIfendEvent

I think this is what you're trying to accomplish. See if you can add conditions to your souls menu, so the buttons only appear if the item count of the empty soul gem is greater than 0.

You could also try the Cast function instead. Have the spell you cast only run a script, and then cast the spell if the right conditions are met. That could get a bit messy though.

Thank you guys so much for all of the help you both have given me, I will apply your advice to my code and will see what happens. When this mod is completed conscider yourselves on the credits for support.