[RELz] Wrye Bash -- Thread 88

Post » Wed May 09, 2012 6:26 am

maura amalia: Thanks for the report. That's a known bug with CBash that happens from time to time, but we haven't narrowed down the cause exactly. Once thing you might check is if Oblivion.esm randomly has a Modification Time later than any other mods.

In other news: Any SVN-ers willing to be a guinea pig? I've tested things out the best I can myself, so now's a good time to have others look for bugs in it. Basically, I want people to test out the new 'Check for Updates' stuff I've been working. Update to the latest SVN (trunk), then to trick Wrye Bash into thinking it's an earlier version, find this line (Edit - in Wrye Bash.txt):
=== 296 [XX/X/2012]
Easiest way is to just search for '296', since that's the only occurrence in the file. Change the 296 to something before 296, for example '271' to make Wrye Bash think it's running version 271, or '295.4' to make it think that, or even '295.5' (if you choose 295.5, the only update it will detect is a Game Definitions file).

Then, launch the new check via 'Settings > Check for Updates > Now' and test it out. Try out as many combinations as you can think of and report back any issues. You'll have to restore Wrye Bash from backup each time (since it'll be overriding with the older 295.5 code).
User avatar
Naomi Lastname
 
Posts: 3390
Joined: Mon Sep 25, 2006 9:21 am

Post » Wed May 09, 2012 12:21 am

Think we should use the Plugin Encoding setting instead, since that string initially came from a CELL name in a plugin?
Yeah, but what if I want to manage other people's saves? :tongue:

Another bug (Latest SVN)
Spoiler
Found Python at 'C:\Python27\python.exe'Launching Wrye Bash in debug modeWrye Bash startingPython version: 2.7.2wxPython version: 2.8.12.1 (msw-unicode)input encoding: cp936; output encoding: None; locale: ('zh_CN', 'cp936')Searching for game to manage:bush.py   80 detectGames: Detected the following supported games via Windows Registry:bush.py   82 detectGames:  oblivion: D:\Bethesda Softworks\Oblivionbush.py   94 detectGames: Detecting games via relative path and the -o argument:bush.py  100 detectGames:  skyrim: D:\Bethesda Softworks\Skyrimbush.py  143 setGame: No preferred game specified.bush.py  150 setGame:  Using skyrim game: D:\Bethesda Softworks\Skyrimbarb.py  185 Apply:barb.py  186 Apply: BASH备份配置D:\Bethesda Softworks\Skyrim Mods\Bash Mod Data\Backup Bash Settings v296 (22-01-2012 1848.35).7zbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Italian.txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Italian.txtbarb.py  190 Apply: Skyrim\Data\Docs\wtxt_teal.css <-- D:\Bethesda Softworks\Skyrim\Data\Docs\wtxt_teal.cssbarb.py  190 Apply: Skyrim\Data\Docs\Bash Readme Template.html <-- D:\Bethesda Softworks\Skyrim\Data\Docs\Bash Readme Template.htmlbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\de.txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\de.txtbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Chinese (Simplified).txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Chinese (Simplified).txtbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Chinese (Simplified).mo <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Chinese (Simplified).mobarb.py  190 Apply: My Games\Skyrim\BashSettings.dat <-- C:\Users\icedream\Documents\My Games\Skyrim\BashSettings.datbarb.py  190 Apply: Skyrim\Data\Docs\Bash Readme Template.txt <-- D:\Bethesda Softworks\Skyrim\Data\Docs\Bash Readme Template.txtbarb.py  190 Apply: Skyrim Mods\Bash Mod Data\Table.dat.bak <-- D:\Bethesda Softworks\Skyrim Mods\Bash Mod Data\Table.dat.bakbarb.py  190 Apply: Skyrim Mods\Bash Mod Data\Table.dat <-- D:\Bethesda Softworks\Skyrim Mods\Bash Mod Data\Table.datbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Russian.txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Russian.txtbarb.py  190 Apply: Skyrim Mods\Bash Installers\Bash\Converters.dat <-- D:\Bethesda Softworks\Skyrim Mods\Bash Installers\Bash\Converters.datbarb.py  190 Apply: Skyrim\Data\Bash Patches\截图autosave2.ess.jpg <-- D:\Bethesda Softworks\Skyrim\Data\Bash Patches\截图autosave2.ess.jpgbarb.py  190 Apply: Skyrim\Data\Docs\wtxt_sand_small.css <-- D:\Bethesda Softworks\Skyrim\Data\Docs\wtxt_sand_small.cssbarb.py  190 Apply: Skyrim\Data\INI Tweaks\Display Tweaks [SkyrimPrefs].ini <-- D:\Bethesda Softworks\Skyrim\Data\INI Tweaks\Display Tweaks [SkyrimPrefs].inibarb.py  190 Apply: My Games\Skyrim\BashSettings.dat.bak <-- C:\Users\icedream\Documents\My Games\Skyrim\BashSettings.dat.bakbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Chinese (Traditional).mo <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Chinese (Traditional).mobarb.py  190 Apply: Skyrim Mods\Bash Installers\Bash\Converters.dat.bak <-- D:\Bethesda Softworks\Skyrim Mods\Bash Installers\Bash\Converters.dat.bakbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\Chinese (Traditional).txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\Chinese (Traditional).txtbarb.py  190 Apply: Skyrim Mods\Bash Installers\Bash\Installers.dat.bak <-- D:\Bethesda Softworks\Skyrim Mods\Bash Installers\Bash\Installers.dat.bakbarb.py  190 Apply: Skyrim\Mopy\bash\l10n\pt_opt.txt <-- D:\Bethesda Softworks\Skyrim\Mopy\bash\l10n\pt_opt.txtbarb.py  190 Apply: Skyrim Mods\Bash Installers\Bash\Installers.dat <-- D:\Bethesda Softworks\Skyrim Mods\Bash Installers\Bash\Installers.datTraceback (most recent call last):  File "Wrye Bash Launcher.pyw", line 33, in 	bash.main()  File "D:\Bethesda Softworks\Skyrim\Mopy\bash\bash.py", line 511, in main	quit = cmdBackup()  File "D:\Bethesda Softworks\Skyrim\Mopy\bash\bash.py", line 80, in cmdBackup	backup.Apply()  File "D:\Bethesda Softworks\Skyrim\Mopy\bash\barb.py", line 201, in Apply	pack7z(self.dir.join(self.archive),self.tmp)  File "D:\Bethesda Softworks\Skyrim\Mopy\bash\barb.py", line 444, in pack7z	progress(index,dstFile.s+u'\n'+_(u'Compressing files...')+u'\n'+maCompressing.group(1).strip())UnicodeDecodeError: 'ascii' codec can't decode byte 0xe6 in position 25: ordinal not in range(128)
User avatar
Alisha Clarke
 
Posts: 3461
Joined: Tue Jan 16, 2007 2:53 am

Post » Tue May 08, 2012 10:31 pm

Actually, looking at the traceback again, I see "bosho" at the top - that's a clue to me saying you have loose python files in the Mopy directory. Probably from installing the Standalone over top of an existing Python version.

With 295.5, I changed the exe so it'll load Python files if present instead of using the internal files. This allows me to push out game definition updates without having to re-release the whole program. Much easier to for me to upload, and users to download, a 35KB file instead of 3 files totaling ~35MB.

Anyway, go through your Mopy directory and subdirectory, and delete any .py, .pyw, and .pyc files, EXCEPT for 'Mopy\bash\oblivion.py' and 'Mopy\bash\skyrim.py'. These last two are the updated game definition files. You can also delete any file without a file extension (like 'bosho', or 'bashero' for example).

I'll have to remember to update the readme with this change to the behavior of the Standalone.
Probably a stupid question, but I will ask anyway...

I noticed that the in the Mopy\bash\game folder there are Oblivion and Skyrim files with .pyc extensions. Do these get updated automatically by copying the new definition .py files into the folder or is there something else I need to do?

Many thanks
User avatar
Meghan Terry
 
Posts: 3414
Joined: Sun Aug 12, 2007 11:53 am

Post » Wed May 09, 2012 7:29 am


Yeah, but what if I want to manage other people's saves? :tongue:

Another bug (Latest SVN)
1 - well, until I implement a per-plugin and per-save file encoding setting, 'Plugin Encoding' will have to do I suppose ;)
2 - I think I know what's going on there. I'll fix it as soon as I'm finished with what I'm working on right now.

Probably a stupid question, but I will ask anyway...

I noticed that the in the Mopy\bash\game folder there are Oblivion and Skyrim files with .pyc extensions. Do these get updated automatically by copying the new definition .py files into the folder or is there something else I need to do?

Many thanks
No need to worry about the .pyc files really. They're the "compiled" version of the .py files, Python automatically generate them as needed. Python's smart too: if the .pyc file exists, it'll use it instead of recompiling...unless it sees that the .py file has been modified, then it will recompile. So yeah, .pyc files are fine (although if there's a .pyc file without it's .py counterpart, that means it's a .pyc file that's not in use anymore, and it's just filling up space now).
User avatar
Brentleah Jeffs
 
Posts: 3341
Joined: Tue Feb 13, 2007 12:21 am

Post » Wed May 09, 2012 1:27 am

In other news: Any SVN-ers willing to be a guinea pig?

Quickly tested this and it seems to work fine (tried by 'setting' it to 295.5 and to 280) - it even asked me whether I wanted to back-up my settings when it noticed the 'downgrades'! The upgrade was easy, and I liked being given various options at every step. Might almost be too many options for complete beginners, especially if they missed a few updates, and 'mark as installed' confused me at first but I like being in control of what I install on my PC and how I install it. Once the features are described in the readme, and maybe a fully automated update option is available, it'll be fine.
Two little things, though. Firstly, the pop-up box informing me that Bash is ready to install the upgrades gave me the options 'yes' and 'no' - 'install' and 'cancel' would probably make more sense. Secondly, should it not offer to back-up settings when automatically restarting after the upgrade?
Also, having restored my settings a few times I noticed that when Bash reaches the point where it has to restart for the settins to come into effect the only option given is to click OK. If someone would prefer not too restart Bash at that point (maybe suddenly remembered that they wanted to quickly install one little plug-in and they'd rather do it now than having to go back into BAIN after a restart) that is not possible. Would it be possible to give the option to delay the restart or - If delaying has bad consequences - add a warning at the beginning of the process that a forced restart will come at the end.
Finally, one little nuisance: while I can now rearrange the icons on the taskbar again, Bash does not remember their new locations. My PC does very occassionally misbehave like that though - eg, it never remembers column width either and I had some squashed boxes on the right hand side which myk kindly spent ages trying to fix but nothing worked - so if I am the only one with this problem don't worry about it. If others have this problem, too, and there is no obvious solution, can the default position of the 'help' icon be moved to the far right (to make it more visable), and maybe move the settings, doc browser, and mod checker buttons to the right too.
Many Thanks for all your hard work!
User avatar
Trevi
 
Posts: 3404
Joined: Fri Apr 06, 2007 8:26 pm

Post » Wed May 09, 2012 1:00 am

Wow :S

Put 290 to wb.txt and (I got asked if I want to save my settings (previous version 260)) and got this nifty new dialogue - everything went smoothly. Maybe change the dialogue :
---------------------------Install Updates---------------------------The following updated files were unable to be applied, because they are currently in use.  Wrye Bash needs to restart to apply these files.  If you choose not to restart, be sure to run 'apply_updates.bat' before running Wrye Bash, to complete the update.  If you choose not to complete the update, Wrye Bash can be restored using the backup archive generated in 'Mopy\backup'.* Mopy\bash\compiled\CBash.dll---------------------------Yes   No  ---------------------------
- [offtopic]I still have to put those xml tags by hand - anyone on this ?[/offtopic]

to explicitly ask for confirmation on restart as in:
---------------------------
Install Updates
---------------------------
The following updated files were unable to be applied, because they are currently in use. Wrye Bash needs to restart to apply these files. If you choose not to restart, be sure to run 'Mopy\apply_updates.bat' before running Wrye Bash, to complete the update. If you choose not to complete the update, Wrye Bash can be restored using the backup archive generated in 'Mopy\backup'.

* Mopy\bash\compiled\CBash.dll

Restart now ?
---------------------------
Yes No
---------------------------

Now that you are at it - would it be possible to expand this system to update to latest svn (or Latest trunk svn, latest branchN svn etc ?)

Tortoise svn will report (after SVN update) a lot of files with a red exclamation mark - any easy workaround (apart from right clicking on each and every file and choosing revert)
EDIT : just right click on Mopy and cjhoose revert - :facepalm:
I admit that version control still escapes me :smile:
User avatar
Phillip Hamilton
 
Posts: 3457
Joined: Wed Oct 10, 2007 3:07 pm

Post » Wed May 09, 2012 3:48 am

Quickly tested this and it seems to work fine (tried by 'setting' it to 295.5 and to 280) - it even asked me whether I wanted to back-up my settings when it noticed the 'downgrades'! The upgrade was easy, and I liked being given various options at every step. Might almost be too many options for complete beginners, especially if they missed a few updates, and 'mark as installed' confused me at first but I like being in control of what I install on my PC and how I install it. Once the features are described in the readme, and maybe a fully automated update option is available, it'll be fine.
Sweet :) Any suggestions on how to make the 'Mark as Installed' feature easier to understand at first glance? As for a "more automated" - if you change the update frequency to "Every time Wrye Bash starts", and tick 'Always update to the latest version', then Wrye Bash wont ask what to download, it'll download, extract, backup your old install...everything up to the point of actually copying the files over. THEN it will ask, "The following updates are ready to be installed, blah blah blah, install?". Although, now that I think about it, the 'Always update to the latest version' checkbox is probably easier if it's in the Check for Updates menu, instead of in the dialog - otherwise the user has to run the update command at least once to enable it.

Two little things, though. Firstly, the pop-up box informing me that Bash is ready to install the upgrades gave me the options 'yes' and 'no' - 'install' and 'cancel' would probably make more sense. Secondly, should it not offer to back-up settings when automatically restarting after the upgrade?
Unfortunately, changing the 'yes' and 'no' buttons is very tricky, since their default windows buttons. I can probably work something out, but maybe just changing the wording of the message would be better?
As for the back-up after restarting...it should ask if you want to back up your settings, as long as the "detected" version has changed (ie, the version read from Wrye Bash.txt). So just installing a Game Definition update or Language pack (non on sourceforge right now), wouldn't actually change the version of the program, so Wrye Bash won't ask to backup settings. If you actually update the program itself, it definitely should be asking to backup, and if it's not, that's a problem.

Also, having restored my settings a few times I noticed that when Bash reaches the point where it has to restart for the settins to come into effect the only option given is to click OK. If someone would prefer not too restart Bash at that point (maybe suddenly remembered that they wanted to quickly install one little plug-in and they'd rather do it now than having to go back into BAIN after a restart) that is not possible. Would it be possible to give the option to delay the restart or - If delaying has bad consequences - add a warning at the beginning of the process that a forced restart will come at the end.
Hmm yes. Not restaring immediately definitely could mess things up. Good suggestion, I'll add it.

Finally, one little nuisance: while I can now rearrange the icons on the taskbar again, Bash does not remember their new locations. My PC does very occassionally misbehave like that though - eg, it never remembers column width either and I had some squashed boxes on the right hand side which myk kindly spent ages trying to fix but nothing worked - so if I am the only one with this problem don't worry about it. If others have this problem, too, and there is no obvious solution, can the default position of the 'help' icon be moved to the far right (to make it more visable), and maybe move the settings, doc browser, and mod checker buttons to the right too.
Many Thanks for all your hard work!
Hmm, there is a little quirkyness going on there. Certain buttons are supposed to always exist, and it seems that those buttons are the ones that aren't quite getting re-ordered correctly (Help, Settings, 'Apps' folder buttons). It seems when any of the non-Apps folder ones get moved (indirectly or directly), it's getting messed up. I'll try to fix that.

[offtopic]I still have to put those xml tags by hand - anyone on this ?[/offtopic]

to explicitly ask for confirmation on restart as in:

Now that you are at it - would it be possible to expand this system to update to latest svn (or Latest trunk svn, latest branchN svn etc ?)

Tortoise svn will report (after SVN update) a lot of files with a red exclamation mark - any easy workaround (apart from right clicking on each and every file and choosing revert)
EDIT : just right click on Mopy and cjhoose revert - :facepalm:
I admit that version control still escapes me :smile:
I have to manually put the xml/code tags as well.

Glad everything else appears to go smoothly for you :)

As for SVN updates - not really. That would require a third party SVN library, which I really don't want to add into the mix, plus I don't belive it will be able to read the ".svn" data that TortoiseSVN stores (it tracks what revision you're on, to know what to download), so it'd have to track info seperately anyway. Not to mention the other files in the SVN that don't normally get installed.
User avatar
Sanctum
 
Posts: 3524
Joined: Sun Aug 20, 2006 8:29 am

Post » Tue May 08, 2012 4:31 pm

Ok, suggestions implemented:
- now the restore settings prompt that asks if you really want to restore settings says that this will force a restart of Wrye Bash
- cleaned up the messages at the end of the update process to say "Restart now?" at the end.
- no longer references 'apply_updates.bat' at all anymore, since I've rigged it to always run, even if you select "No" to restart.

Also: bluesky404 - the backup settings should work now without unicode errors now (wasn't processing the 7z output into unicode, now it is)
User avatar
Stacyia
 
Posts: 3361
Joined: Mon Jul 24, 2006 12:48 am

Post » Tue May 08, 2012 9:39 pm

Sweet :smile: Any suggestions on how to make the 'Mark as Installed' feature easier to understand at first glance?
Can you have mouse-over tooltips? I am assuming it to mean something like 'I have already installed this manually (eg. from SVN), but Bash is not detecting it so please mark it as installed' so you could just put something like that in the tooltip.
As for a "more automated" - if you change the update frequency to "Every time Wrye Bash starts", and tick 'Always update to the latest version', then Wrye Bash wont ask what to download, it'll download, extract, backup your old install...everything up to the point of actually copying the files over. THEN it will ask, "The following updates are ready to be installed, blah blah blah, install?". Although, now that I think about it, the 'Always update to the latest version' checkbox is probably easier if it's in the Check for Updates menu, instead of in the dialog - otherwise the user has to run the update command at least once to enable it.
That sounds ideal for beginners, although hopefully it will also work on different update-check-frequencies. After all, if someone was that desperate to always have the latest version they would learn to use the SVN, but doing an update check on every Bash start would make bash seem really sluggish to start.
Unfortunately, changing the 'yes' and 'no' buttons is very tricky, since their default windows buttons. I can probably work something out, but maybe just changing the wording of the message would be better?
A simple 'do you want to install these files' would do. It is pretty obvious what is meant anyway, but better make it as clear as possible.
As for the back-up after restarting...it should ask if you want to back up your settings, as long as the "detected" version has changed (ie, the version read from Wrye Bash.txt). So just installing a Game Definition update or Language pack (non on sourceforge right now), wouldn't actually change the version of the program, so Wrye Bash won't ask to backup settings. If you actually update the program itself, it definitely should be asking to backup, and if it's not, that's a problem.
As 'updating' from 295.5 only updated the Game Definitions that should be fine, thanks for the explanation. Good to know that Bash is less confused by me playing with different versions than I am myself!
Hmm, there is a little quirkyness going on there. Certain buttons are supposed to always exist, and it seems that those buttons are the ones that aren't quite getting re-ordered correctly (Help, Settings, 'Apps' folder buttons). It seems when any of the non-Apps folder ones get moved (indirectly or directly), it's getting messed up. I'll try to fix that.
Could you put them in a separate task bar on its own and move that to the right? Although so long as they either remember their new location or their defaults are changed to be more visible that'll be fine.
User avatar
Jeff Turner
 
Posts: 3458
Joined: Tue Sep 04, 2007 5:35 pm

Post » Wed May 09, 2012 5:45 am

Can you have mouse-over tooltips? I am assuming it to mean something like 'I have already installed this manually (eg. from SVN), but Bash is not detecting it so please mark it as installed' so you could just put something like that in the tooltip.
Good idea actually. I'll do that, and if anyone has any better ideas to make it clear, maybe I can do that too.

That sounds ideal for beginners, although hopefully it will also work on different update-check-frequencies. After all, if someone was that desperate to always have the latest version they would learn to use the SVN, but doing an update check on every Bash start would make bash seem really sluggish to start.
Actually, the whole update process spawns a separate process to do the work, so the UI is still responsive the whole time (except when user interaction is required of course).

A simple 'do you want to install these files' would do. It is pretty obvious what is meant anyway, but better make it as clear as possible.
Done.

And status bar buttons: I'll figure it out, probably tomorrow though.
User avatar
Kelsey Hall
 
Posts: 3355
Joined: Sat Dec 16, 2006 8:10 pm

Post » Tue May 08, 2012 5:27 pm

Actually, the whole update process spawns a separate process to do the work, so the UI is still responsive the whole time (except when user interaction is required of course).
That's good to hear. I am sure you have also already implemented a suitable error message or other response in case of no internet connection...
User avatar
Avril Louise
 
Posts: 3408
Joined: Thu Jun 15, 2006 10:37 pm

Post » Wed May 09, 2012 12:51 am

Does Standalone version also have 'Marked as Installed'? I can only see it in python version. :smile:

Edit: While downloading Standalone version, click status bar, get
Spoiler
Traceback (most recent call last):
File "wx\_misc.pyo", line 1358, in Notify
File "wx\_core.pyo", line 14771, in Notify
File "bash\basher.pyo", line 5581, in CheckDownloadStatus
File "wx\_core.pyo", line 14705, in __init__
File "wx\_core.pyo", line 14721, in Start
File "wx\_misc.pyo", line 1353, in __init__
File "wx\_misc.pyo", line 1296, in __init__
wx._core.PyAssertionError: C++ assertion "wxAssertFailure" failed at ..\..\src\common\wincmn.cpp(2571) in DoNotifyWindowAboutCaptureLost(): window that captured the mouse didn't process wxEVT_MOUSE_CAPTURE_LOST
User avatar
Jessie
 
Posts: 3343
Joined: Sat Oct 14, 2006 2:54 am

Post » Wed May 09, 2012 12:18 am

Yep, standalone version does - however you can only 'Mark as installed' Game Definition updates and Language packs. If you just don't want to update the version, you'd just make sure the update frequency is 'Never', and manually check if you want to see if there's an update.

That's good to hear. I am sure you have also already implemented a suitable error message or other response in case of no internet connection...
Well, the error message might be a little esoteric to the user, but it's shown in a nice dialog that say "There was an error blah bla blah: ", so it's nothing like the usual bash errors where it's in the stdout/stderr box. And I say cryptic, here's an example:

Check for Updates------------------------------------------------An error occurred while contacting SourceForge:------------------------------------------------OK
So might not make sense to everyone, but the gist of it is there.

Edit: Re bluesky's bug - ouch. Looks like the status bar drag and drop code is getting messed up when focus is trying to get stolen away from it by the update dialog. I'll have to work out a to make them play nicely.
User avatar
Sandeep Khatkar
 
Posts: 3364
Joined: Wed Jul 18, 2007 11:02 am

Post » Tue May 08, 2012 3:52 pm

Yep, standalone version does
http://www.bild.me/bild.php?file=4767137checkforupdate.png...
SVN 2278

Edit: oops, after testing python, I forgot to reset update info.
Reset update info, now it works.

Edit Edit: Oh, only standalone version have update log?
Also curious why bash would say Wrye Bash.exe is being used, but not for Wrye Bash Launcher.pyw?
User avatar
amhain
 
Posts: 3506
Joined: Sun Jan 07, 2007 12:31 pm

Post » Wed May 09, 2012 1:31 am

http://www.bild.me/bild.php?file=4767137checkforupdate.png...
SVN 2278
Ah, yeah. Sorry - I forgot. You can only mark updates as installed if it's for the version of Wrye Bash you already have installed, since it tracks updates by what version they belong to - marking updates for 295.5 as installed when you only have 290 or something doesn't make sense for Wrye Bash. I know, even if you select to update to 295.5 at the same time, you'd think you could update and mark the other as installed all in one swoop. But - installing 295.5 will erase the update you say you have installed, so you shouldn't be able to mark it as installed.

If you're just trying to make it ignore the update, sorry - you'll have to run the check for updates again, THEN mark it as installed.


Re: status bar error - Ok, so I've narrowed it down to a very short window when it can happen, dealing with events and what order they get added to the even queue. I'm pretty stumped on how to prevent it right now without killing either 1) status bar drag and drop, or 2) actually being able to click the status bar buttons.

So this one might take a while, and I need some :snoring:
User avatar
Dan Endacott
 
Posts: 3419
Joined: Fri Jul 06, 2007 9:12 am

Post » Wed May 09, 2012 12:29 am

Minor point for the Status Bar: TES4Gecko and Settings have the same icon - would be good to change the TES4Gecko icon to something different (Perhaps the Java Icon that is used in the Task Bar when TES4Gecko is running).
User avatar
KiiSsez jdgaf Benzler
 
Posts: 3546
Joined: Fri Mar 16, 2007 7:10 am

Post » Wed May 09, 2012 3:49 am

What games did it say were detected. Also, generate a bugdump by launching Wrye Bash.exe with the '-d' switch, like so:
>"Wrye Bash.exe" -d
The bugdump will provide more information on the game detection process.


Actually it did not detect any game.
I created file called Wrye.bat where i put: "Wrye Bash.exe" -d
It generated bugdump.txt where is written: Python not found

The problem is I installed Standalone version. Latest from Nexus. There's also an update which I probably should install aswell.
User avatar
HARDHEAD
 
Posts: 3499
Joined: Sun Aug 19, 2007 5:49 am

Post » Wed May 09, 2012 6:11 am

As for SVN updates - not really. That would require a third party SVN library, which I really don't want to add into the mix, plus I don't belive it will be able to read the ".svn" data that TortoiseSVN stores (it tracks what revision you're on, to know what to download), so it'd have to track info seperately anyway. Not to mention the other files in the SVN that don't normally get installed.
No no - I meant implement svn updates as in downloading the latest svn from within Bash - and getting rid of tortoise svn completely. I don't really use the .svn folders - I just use tortoise svn for downloading latest svn

btw thanks for all the great work recently :smile:
User avatar
Sara Johanna Scenariste
 
Posts: 3381
Joined: Tue Mar 13, 2007 8:24 pm

Post » Wed May 09, 2012 3:17 am

Actually it did not detect any game.
I created file called Wrye.bat where i put: "Wrye Bash.exe" -d
It generated bugdump.txt where is written: Python not found

The problem is I installed Standalone version. Latest from Nexus. There's also an update which I probably should install aswell.
Uuuurrrrgg? What are you system specs? The only thing I can come up with is maybe the internal Python interpreter is failing to load. Did the standalone work for you with previous versions? This is 295.5, correct? You also have the MSVC 2008 runtime installed correct?

No no - I meant implement svn updates as in downloading the latest svn from within Bash - and getting rid of tortoise svn completely. I don't really use the .svn folders - I just use tortoise svn for downloading latest svn
Ah - could be done, yes, however I'd rather not. Downloading updates via an SVN client *only* downloads diffs of the files (so one small change to basher.py will only take a few bytes), rather than the whole file all over again. Downloading the GNU tarball each time would put a significant increase on both download time, the SVN server traffic (IIRC, it's not mirrored like the file downloads are). Couple this with the fact that updates to the SVN are much more frequent... Not to mention that often times a commit to the SVN breaks Wrye Bash, it'd be fun to have bash auto-update to a broken version right ;)

Anyway, I think SVN should be best left to an SVN client.

btw thanks for all the great work recently :smile:
You don't even want to know how much time I spent on this, making sure it was perfect before committing it. A botched update would be disastrous for users.



Edit Edit: Oh, only standalone version have update log?
Also curious why bash would say Wrye Bash.exe is being used, but not for Wrye Bash Launcher.pyw?
Because of the way Python works - Wrye Bash Launcher.pyw (and other .py files) is only loaded long enough to compile into byte-code, then the byte-code is used from then on and the file is free to be edited/deleted/replaced, etc.
User avatar
marie breen
 
Posts: 3388
Joined: Thu Aug 03, 2006 4:50 am

Post » Tue May 08, 2012 5:18 pm

One more bug report on status bar
I just dnd and rearranged the icon order, then changed Icon Size, the icon order revert to the old one, restart wrye bash, and the icon order remained the old one. I've got no idea how to change the icon order, accidently found that OBMM icon is in front of 'auto-quit'. (unsure when or why it changed :shrug:)

And, if I start Wrye Bash in L command line, then change global settings->language, bash restart but the language is still determined by -L, not global settings. ;)
User avatar
Jennifer May
 
Posts: 3376
Joined: Thu Aug 16, 2007 3:51 pm

Post » Tue May 08, 2012 5:38 pm

Uuuurrrrgg? What are you system specs? The only thing I can come up with is maybe the internal Python interpreter is failing to load. Did the standalone work for you with previous versions? This is 295.5, correct? You also have the MSVC 2008 runtime installed correct?

My system is Windows 7 64-bit, Gigabyte EP43-S3L (Motherboard), Intel Core 2 Duo CPU E7400 @ 2.80GHz, 4096MB RAM (DDR2 @ 800Mhz), Gigabyte NVIDIA GeForce GTX 260 Super Overclock.
Standalone was working before. That's up-to date 295.5 but without this update of game definitions (we should always download it from Nexus to have something in WB updated right?).
I have installed Microsoft Visual C++ 2008 Redistributable x86 - 9.0.30729.17.
User avatar
A Boy called Marilyn
 
Posts: 3391
Joined: Sat May 26, 2007 7:17 am

Post » Tue May 08, 2012 10:33 pm

I've had this issue with WB 295.1 that if I fiddled around in the Installers tab, and later tried to rebuild bashed patch (Cbash), it would always crash. If I started WB fresh, and rebuilt patch without changing tabs (OK to change from Mods to Saves, ini or Screenshots, but NOT Installers), then the bashed patch is built fine.

Upgraded to WB 295.5 yesterday, tried building patch after fiddling around with files in the Installers tab. Crashed with the following error report:

Spoiler

Traceback (most recent call last):
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\basher.py", line 5349, in OnCloseWindow
self.SaveSettings()
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\basher.py", line 5361, in SaveSettings
self.notebook.GetPage(index).OnCloseWindow()
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\basher.py", line 2554, in OnCloseWindow
bosh.modInfos.table.save()
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\bolt.py", line 2158, in save
self.hasChanged = not dictFile.save()
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\bosh.py", line 315, in save
saved = bolt.PickleDict.save(self)
File "F:\Bethesda Softworks\Oblivion\Mopy\bash\bolt.py", line 1910, in save
cPickle.dump(data,out,-1)
MemoryError


Again, it's fine if I build bashed patch after starting WB fresh.

Thought I'd mention and see if that helps you figure it out.

Specs:
Win 7 64 bit
6 GB RAM, intel i7 930, 80 GB SSD
WB standalone w/ CBash 0.53 bashed patch

Will bump this as was overlooked earlier.
User avatar
lillian luna
 
Posts: 3432
Joined: Thu Aug 31, 2006 9:43 pm

Post » Tue May 08, 2012 6:22 pm

:stare: I notice that the TESNexus download page description no longer mentions v295 at all. And the "Game Definitions" file is not described ANYWHERE other than the file description, where it is listed as "Optional". New Oblivon players still show up all the time. 3K-Alpha does not look like a good solution for just Oblivion at the moment. Right now that page would scare me away from WB. Suggest it needs some lovin'.

-Dubious-
User avatar
abi
 
Posts: 3405
Joined: Sat Nov 11, 2006 7:17 am

Post » Wed May 09, 2012 1:36 am

One more bug report on status bar
I just dnd and rearranged the icon order, then changed Icon Size, the icon order revert to the old one, restart wrye bash, and the icon order remained the old one. I've got no idea how to change the icon order, accidently found that OBMM icon is in front of 'auto-quit'. (unsure when or why it changed :shrug:)

And, if I start Wrye Bash in L command line, then change global settings->language, bash restart but the language is still determined by -L, not global settings. ;)
Status Bar - working on it. I think I may have to revamp it to get it to work better.

Language: I can't reproduce, is this with the latest SVN? Is this after an update, but selection "No" to restart?

My system is Windows 7 64-bit, Gigabyte EP43-S3L (Motherboard), Intel Core 2 Duo CPU E7400 @ 2.80GHz, 4096MB RAM (DDR2 @ 800Mhz), Gigabyte NVIDIA GeForce GTX 260 Super Overclock.
Standalone was working before. That's up-to date 295.5 but without this update of game definitions (we should always download it from Nexus to have something in WB updated right?).
I have installed Microsoft Visual C++ 2008 Redistributable x86 - 9.0.30729.17.
Looking back at your original post... I think you may have reported wrong information to me. Your first post indecates the Python is working 100% (otherwise it'd never be able to give you the message about not being able to determine the game to manage. So let's do this again:
First, delete "Wrye Bash.exe.log" if it exists. Then, run this command:
>"Wrye Bash.exe" -d
The output from this will be in "Wrye Bash.exe.log" (NOT "BashBugDump.txt" or "bugdump.txt"). Once you select "Quit" on the button on that first window, you should also get a message saying something to the effect of "errors occurred, see Wrye Bash.exe.log for more details". Then post the full contents of "Wrye Bash.exe.log" here.

Will bump this as was overlooked earlier.
Well, the issue is Python hitting the 2GB limit. Long technical explanation: settings are saved using the cPickle module, which saves binary representations of data types. There are tricks to make it use smaller bits of data to represent larger objects - these have already been done. The problem comes in where cPickle has to do extra processing to track shared objects - this adds some memory overhead to the process. If the data being saved is large enough, and the process memory is already high, this can push it over the 2GB limit and give a memory error.

I'll work on seeing if there's a way we can combat this, but this is something that wont be fixed quickly, it'll probably require lots of internal changes. In the meantime, avoid rebuilding the Bashed Patch after visiting the Installers Tab. It seems you have enough data from the Installers Tab to push you over the edge.

:stare: I notice that the TESNexus download page description no longer mentions v295 at all. And the "Game Definitions" file is not described ANYWHERE other than the file description, where it is listed as "Optional". New Oblivon players still show up all the time. 3K-Alpha does not look like a good solution for just Oblivion at the moment. Right now that page would scare me away from WB. Suggest it needs some lovin'.

-Dubious-
Bleh, ok.
User avatar
Sun of Sammy
 
Posts: 3442
Joined: Mon Oct 22, 2007 3:38 pm

Post » Tue May 08, 2012 9:02 pm

Thanks for the explanation Lojack - indeed, I have 1000+ 7z files in my installers tab that might be contributing to the 2 GB limit.

Is there no way to make Wrye Bash large address aware (LAA) for 64 bit users, similar to what we do with the Oblivion exe?- I am not wven sure what that entails considering we don't have an exe, so will just leave this for you to ponder.
User avatar
sunny lovett
 
Posts: 3388
Joined: Thu Dec 07, 2006 4:59 am

PreviousNext

Return to IV - Oblivion