Wrye Mash Thread #5

Post » Tue May 17, 2011 4:22 am

There should be some error handling added to your DoAll solution in case more than 255 plugins exist in Data Files. Suggest using the error check from the DoList block, like so:

    def DoAll(self,event):        for loadFile in mosh.modInfos.data:            try:                mosh.modInfos.load(loadFile,False)            except mosh.MaxLoadedError:                ErrorMessage(self.window,_("Unable to add mod %s because load list is full.")                     % (loadFile,))                break        mosh.mwIniFile.safeSave()        #--Refresh entries        self.window.PopulateItems()

Interestingly, the plugins that get checked as active up to the limit of 255 are not necessarily those in the order from top to bottom as sorted by column in the Mods tab - probably because mosh.modInfos.data is propagated as new plugins are added. So your solution will really only work as expected for < 256 plugins. <_<
User avatar
Lalla Vu
 
Posts: 3411
Joined: Wed Jul 19, 2006 9:40 am

Post » Tue May 17, 2011 2:38 am

Thanks i wasn't aware of that limitation. Looking around now, it seems that that was never supported? So putting a warning there is correct. If you want to order them in the same order as the current table order, thats fine by me, though i myself would consider that unnecessary considering the warning. Regardless, if you want to attempt that, you'll have to access the internal "ListView" equivalent on WXWidgets.
User avatar
james kite
 
Posts: 3460
Joined: Sun Jul 22, 2007 8:52 am

Post » Tue May 17, 2011 12:44 am

Here is how "impossible" it is:
go into line 5448 of masher.py
duplicate the function DoNone there and rename it, and slightly alter it.
	def DoAll(self,event):		        for loadFile in mosh.modInfos.data:			       mosh.modInfos.load(loadFile,0)			mosh.mwIniFile.safeSave()			#--Refresh entries			self.window.PopulateItems()

Then go into line 5443
You see the
wx.EVT_MENU(window,ID_LOADERS.NONE,self.DoNone)
line there?
Duplicate it and alter it into
wx.EVT_MENU(window,ID_LOADERS.ALL,self.DoAll)

Now go into line 5429
menu.Append(ID_LOADERS.NONE,_('None'))
duplicate it and alter it into
menu.Append(ID_LOADERS.ALL,_('All'))
Now go into line 314
You see this line:
ID_LOADERS = IdList(10000,90,'SAVE','EDIT','NONE')
Don't duplicate it. Just alter it to
ID_LOADERS = IdList(10000,90,'SAVE','EDIT','ALL','NONE')

Now to compile. The easy part right?

install these
http://www.python.org/ftp/python/2.5/python-2.5.msi
http://downloads.sourceforge.net/project/wxpython/wxPython/2.8.0.1/wxPython2.8-win32-ansi-2.8.0.1-py25.exe?r=http%3A%2F%2Fwryemusings.com%2FWrye%2520Mash.html&ts=1296778474&use_mirror=freefr

testing from the command line with
wine "C:\Python25\python.exe" mash.py

shows the alterations work.

but i can't compile the stand alone executable from wine. It is SNAFU from root (probably a bug on wine). Trust me i tried.

So, now that i've given you a way to do it, could you do me the favor of putting this in the next version?
Thanks for the help, I will try if I am able to make your suggested code work with Python 2.7 in my Mash source code version (with which I am perfectly happy).
As I said, for me adding the functionality you asked for was impossible because I currently lack the necessary knowledge, maybe this is true also for whoever is following the development of the compiled version... was it so difficult to share your knowledge/expertise before asking somewhat rudely?

[EDIT]Also, thanks @tetchy for the info...
User avatar
Dean Ashcroft
 
Posts: 3566
Joined: Wed Jul 25, 2007 1:20 am

Post » Tue May 17, 2011 4:24 am



BTW, that is really [censored] up in wine. Impossible to compile even if i got the correct dependencies, correct dependencies not on the readme, needed to copy the python25.dll manually, error creating the src.zip and copying it (deleted that in the setup.py), warnings because of missing modules (even with the recommended versions from the wrye homepage), error linking (copying the msvcp.dll or msvcr.dll to the dir doesn't solve it, dependencywalker application says it needs msvcr.dll, instead of the msvcp.dll that setup.py copies), etc. If finding the right list to iterate on that piece of code took 30 minutes, trying to compile the standalone exe and fail took 5 hours.

It's probably wine.
User avatar
Ricky Rayner
 
Posts: 3339
Joined: Fri Jul 13, 2007 2:13 am

Post » Tue May 17, 2011 11:02 am

No problems. Let's everybody contribute to make things better. Your + tetchy's suggested changes work well :tops: (not that I needed them particularly, but if I ever need to access checked mods list instead of selected mods list now I know how to do)
User avatar
Ray
 
Posts: 3472
Joined: Tue Aug 07, 2007 10:17 am

Post » Tue May 17, 2011 9:41 am

i'm using the standalone version of mash and i always get the following error message:

'Traceback (most recent call last):
File "masher.pyo", line 3105, in RefreshData
TypeError: not all arguments converted during string formatting'

can please someone tell me what to do?
User avatar
Taylah Haines
 
Posts: 3439
Joined: Tue Feb 13, 2007 3:10 am

Post » Tue May 17, 2011 2:26 pm

I've reinstalled morrowind and with it wrye mash.
However, while wrye mash is installed in a non-standard directory, the installer tab is placed in the standard one.
Is there a way to change it to the morrowind folder?
In the readme it stated Mash would ask if Morrowind was installed somewhere else, but I didn't get this message...
User avatar
Rude Gurl
 
Posts: 3425
Joined: Wed Aug 08, 2007 9:17 am

Post » Tue May 17, 2011 2:19 pm

If you're using python based Wrye Mash just copy the Installers folder to the game folder or is it Wrye Mash Stand Alone just click on the green disk icon on the bottom. :)
User avatar
Yonah
 
Posts: 3462
Joined: Thu Aug 02, 2007 4:42 am

Post » Tue May 17, 2011 6:45 am

I've reinstalled morrowind and with it wrye mash.
However, while wrye mash is installed in a non-standard directory, the installer tab is placed in the standard one.
Is there a way to change it to the morrowind folder?
In the readme it stated Mash would ask if Morrowind was installed somewhere else, but I didn't get this message...


edit the sinstallersdir entry in Mopy/mash.ini
User avatar
..xX Vin Xx..
 
Posts: 3531
Joined: Sun Jun 18, 2006 6:33 pm

Post » Tue May 17, 2011 2:08 pm

Is it just me, or does Ctrl + Up/Down arrow keys not work for sorting load order? Wrye Bash allows such a thing and I think it's very convenient. Can this be added into Wrye Mash?
User avatar
jessica sonny
 
Posts: 3531
Joined: Thu Nov 02, 2006 6:27 pm

Post » Tue May 17, 2011 12:31 am

Is it just me, or does Ctrl + Up/Down arrow keys not work for sorting load order? Wrye Bash allows such a thing and I think it's very convenient. Can this be added into Wrye Mash?

No, it's not you in fact there is not such feature available yet for Wrye Mash, but I told Melchor (he release the Wrye Mash Stand Alone) about that feature so I might be available in the next WMSA version when he returns. :)
User avatar
james kite
 
Posts: 3460
Joined: Sun Jul 22, 2007 8:52 am

Post » Tue May 17, 2011 4:58 am

Good to hear. I prefer WMSA anyway, so that's even better. ;) Can't believe we've been using this tool for so many years without Ctrl + Up/Down...
User avatar
Rudy Paint fingers
 
Posts: 3416
Joined: Sun Nov 11, 2007 1:52 am

Post » Tue May 17, 2011 8:13 am

Is the Wrye Mash stand alone any different from Wrye Mash? Source code wise?

EDIT:
Starts on Linux now (note. Lots of things won't work on Linux, so it is in no way Linux compatible)
https://github.com/Yacoby/Wrye-Mash
User avatar
FABIAN RUIZ
 
Posts: 3495
Joined: Mon Oct 15, 2007 11:13 am

Post » Tue May 17, 2011 3:59 pm

Meh. Ctrl based sorting works. Sortof. Maybe. There are a few bugs. Mabye. Maybe not :shrug:

I should test it a bit better. :P

Edit
Ok. It seems to work fine. I haven't tried it with any more than two mods though. Performance may svck with a larger number of mods. Idk.


EDIT:
There are a few issues in how it works. For example, it doesn't work with multiple selected items. There may also be issues if the time difference is too small between two mods. I will fix it at some point :)
User avatar
Thema
 
Posts: 3461
Joined: Thu Sep 21, 2006 2:36 am

Post » Tue May 17, 2011 9:00 am

Well TBH, I guess right now it doesn't really matter whether I use WM or WMSA... if WM implements Ctrl sorting, then so be it; I'll ditch WMSA and move back to WM. I have Wrye Python on my system installed anyway, so WM would be just fine for my purposes.

But the only reason I still have the Wrye Python stuff still intact on my system is because there is no Wrye Bash standalone.

If there was a WBSA, I would've already uninstalled Wrye Python, and also exclusively use WMSA and WBSA. :)

I've already stated why I prefer the standalone versions in some old WB thread... basically, I prefer to maintain a clean install on my OS (Wrye Python adds a bunch of entries). It doesn't BOTHER me, but if I was given the option, I'd choose standalone.
User avatar
Kellymarie Heppell
 
Posts: 3456
Joined: Mon Jul 24, 2006 4:37 am

Post » Tue May 17, 2011 9:41 am

But the only reason I still have the Wrye Python stuff still intact on my system is because there is no Wrye Bash standalone.

If there was a WBSA, I would've already uninstalled Wrye Python, and also exclusively use WMSA and WBSA. :)

You don't need python anymore if that's what you really want, because there is a stand alone version for both http://www.gamesas.com/index.php?/topic/1106095-wrye-mash-stand-alone/ & http://www.gamesas.com/index.php?/topic/1176905-relz-wrye-bash-thread-62/. :D
User avatar
Tiffany Carter
 
Posts: 3454
Joined: Wed Jul 19, 2006 4:05 am

Post » Tue May 17, 2011 3:24 pm

Meh. Ctrl based sorting works. Sortof. Maybe. There are a few bugs. Mabye. Maybe not :shrug:

I should test it a bit better. :P

Edit
Ok. It seems to work fine. I haven't tried it with any more than two mods though. Performance may svck with a larger number of mods. Idk.


EDIT:
There are a few issues in how it works. For example, it doesn't work with multiple selected items. There may also be issues if the time difference is too small between two mods. I will fix it at some point :)


Great! Thanks for the hard work. I have one additional feature request:

BAIN has some problems with mods packed like this:

Folder/
Folder/Data/Textures/whatever.dds

I need to repack the archive so it looks like this:

Data/Textures/whatever.dds

Is it possible to somehow fix it?

Is the Wrye Mash stand alone any different from Wrye Mash? Source code wise?

Yes. It has some additional features. The "Utilities" tab for example.
User avatar
ijohnnny
 
Posts: 3412
Joined: Sun Oct 22, 2006 12:15 am

Post » Tue May 17, 2011 3:14 pm

Yes. It has some additional features. The "Utilities" tab for example.
I just noticed this :P. I am going to merge them before my changes start getting out of hand.




Great! Thanks for the hard work. I have one additional feature request:

BAIN has some problems with mods packed like this:

Folder/
Folder/Data/Textures/whatever.dds

I need to repack the archive so it looks like this:

Data/Textures/whatever.dds

Is it possible to somehow fix it?

Maybe. I need to do some work on another project, so I am not going to look at it tonight though.
User avatar
Laura Wilson
 
Posts: 3445
Joined: Thu Oct 05, 2006 3:57 pm

Post » Tue May 17, 2011 6:33 am

You don't need python anymore if that's what you really want, because there is a stand alone version for both http://www.gamesas.com/index.php?/topic/1106095-wrye-mash-stand-alone/ & http://www.gamesas.com/index.php?/topic/1176905-relz-wrye-bash-thread-62/. :D


Ah, thanks for the heads up! I'm glad the WB developers (or whoever was responsible for WBSA) took the suggestion. :D
User avatar
Paula Ramos
 
Posts: 3384
Joined: Sun Jul 16, 2006 5:43 am

Post » Tue May 17, 2011 11:47 am

Ah, thanks for the heads up! I'm glad the WB developers (or whoever was responsible for WBSA) took the suggestion. :D

You're welcome. :)

Nah, that was not the WB team that took the step into a stand alone, because it was us the users who beg them to develop WBSA. :whistling:
User avatar
Sharra Llenos
 
Posts: 3399
Joined: Wed Jan 17, 2007 1:09 pm

Previous

Return to III - Morrowind